Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2622973002:
MD Settings People: Fix ChromeOS Change Picture Profile Icon tooltip (Closed)
|
Created:
3 years, 11 months ago by tommycli Modified:
3 years, 11 months ago CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD Settings People: Fix ChromeOS Change Picture Profile Icon tooltip
This fixes a regression where the tooltip to the profile picture is
never updated.
BUG=676782
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2622973002
Cr-Commit-Position: refs/heads/master@{#442755}
Committed: https://chromium.googlesource.com/chromium/src/+/506bf2924d4de457f71448594c43c79315b86783
Patch Set 1 #
Messages
Total messages: 18 (10 generated)
Description was changed from ========== MD Settings People: Fix ChromeOS Change Picture Profile Icon tooltip This fixes a regression where the tooltip to the profile picture is never updated. BUG=676782 ========== to ========== MD Settings People: Fix ChromeOS Change Picture Profile Icon tooltip This fixes a regression where the tooltip to the profile picture is never updated. BUG=676782 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
tommycli@chromium.org changed reviewers: + stevenjb@chromium.org
stevenjb: PTAL, thanks!
dbeam@chromium.org changed reviewers: + dbeam@chromium.org
lgtm
The CQ bit was checked by tommycli@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by tommycli@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by tommycli@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1484095144801540, "parent_rev":
"2bc46a6dd144aa85e0aecd8f16631dc6bbdfa11e", "commit_rev":
"506bf2924d4de457f71448594c43c79315b86783"}
Message was sent while issue was closed.
Description was changed from ========== MD Settings People: Fix ChromeOS Change Picture Profile Icon tooltip This fixes a regression where the tooltip to the profile picture is never updated. BUG=676782 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings People: Fix ChromeOS Change Picture Profile Icon tooltip This fixes a regression where the tooltip to the profile picture is never updated. BUG=676782 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2622973002 Cr-Commit-Position: refs/heads/master@{#442755} Committed: https://chromium.googlesource.com/chromium/src/+/506bf2924d4de457f71448594c43... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/506bf2924d4de457f71448594c43... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
