Issue 2622953002: fix regression to analysis_server tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2622953002: fix regression to analysis_server tests (Closed)

Created:
3 years, 11 months ago by Jennifer Messerly

Modified:
3 years, 11 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

fix regression to analysis_server tests R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/42341c2abc2ef230560bfeadd97ebf1da811da44

Patch Set 1 #

Total comments: 1

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	pkg/analyzer/lib/src/generated/static_type_analyzer.dart	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Jennifer Messerly

Thanks for the ping Paul! https://codereview.chromium.org/2622953002/diff/1/pkg/analyzer/lib/src/generated/static_type_analyzer.dart File pkg/analyzer/lib/src/generated/static_type_analyzer.dart (right): https://codereview.chromium.org/2622953002/diff/1/pkg/analyzer/lib/src/generated/static_type_analyzer.dart#newcode1912 pkg/analyzer/lib/src/generated/static_type_analyzer.dart:1912: } else if (type ...

3 years, 11 months ago (2017-01-10 19:00:48 UTC) #2

Jennifer Messerly

3 years, 11 months ago (2017-01-10 19:02:40 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
42341c2abc2ef230560bfeadd97ebf1da811da44 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages