Simplify registration of a test ChromeBrowserStateManager.

Simplify registration of a test ChromeBrowserStateManager.

Unit test must cleanup after themselves if the register a test
ChromeBrowserStateManager with the ApplicationContext. Introduce
IOSChromeScopedTestingChromeBrowserStateManager to help with the
registration by using RAII.

BUG=None

Review-Url: https://codereview.chromium.org/2622913002
Cr-Commit-Position: refs/heads/master@{#442646}
Committed: https://chromium.googlesource.com/chromium/src/+/aa8e4c9b15d480285490e8343a419379a4b57889

[sdefresne, 2017-01-10 14:20:58]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 14:21:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-01-10 14:22:46]

sdefresne@chromium.org changed reviewers:
+ rohitrao@chromium.org

[sdefresne, 2017-01-10 14:22:47]

https://codereview.chromium.org/2622913002/diff/1/ios/chrome/test/BUILD.gn
File ios/chrome/test/BUILD.gn (right):

https://codereview.chromium.org/2622913002/diff/1/ios/chrome/test/BUILD.gn#ne...
ios/chrome/test/BUILD.gn:128: "//ios/chrome/browser/omaha:unit_tests",
Those tests were never run!

[sdefresne, 2017-01-10 14:27:25]

https://codereview.chromium.org/2622913002/diff/1/ios/chrome/browser/omaha/om...
File ios/chrome/browser/omaha/omaha_service_unittest.mm (right):

https://codereview.chromium.org/2622913002/diff/1/ios/chrome/browser/omaha/om...
ios/chrome/browser/omaha/omaha_service_unittest.mm:83: web::TestWebThreadBundle
thread_bundle_;
Using web::TestWebThreadBundle is better than using web::TestWebThread.

[commit-bot: I haz the power, 2017-01-10 15:22:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 15:22:47]

Dry run: This issue passed the CQ dry run.

[rohitrao (ping after 24h), 2017-01-10 17:22:09]

lgtm

https://codereview.chromium.org/2622913002/diff/1/ios/chrome/browser/ui/setti...
File ios/chrome/browser/ui/settings/settings_navigation_controller_unittest.mm
(right):

https://codereview.chromium.org/2622913002/diff/1/ios/chrome/browser/ui/setti...
ios/chrome/browser/ui/settings/settings_navigation_controller_unittest.mm:78:
web::TestWebThreadBundle thread_Bundle_;
Capital B?

[sdefresne, 2017-01-10 17:51:25]

https://codereview.chromium.org/2622913002/diff/1/ios/chrome/browser/ui/setti...
File ios/chrome/browser/ui/settings/settings_navigation_controller_unittest.mm
(right):

https://codereview.chromium.org/2622913002/diff/1/ios/chrome/browser/ui/setti...
ios/chrome/browser/ui/settings/settings_navigation_controller_unittest.mm:78:
web::TestWebThreadBundle thread_Bundle_;
On 2017/01/10 17:22:09, rohitrao wrote:
> Capital B?

Fixed.

[sdefresne, 2017-01-10 17:51:39]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2017-01-10 17:51:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
rohitrao@chromium.org
Link to the patchset: https://codereview.chromium.org/2622913002/#ps20001
(title: "Fix typo in naming variable.")

[commit-bot: I haz the power, 2017-01-10 17:51:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 19:05:50]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484070699608100,
"parent_rev": "a6e8cd6a118d18cef16398294ca5b44e6f723dff", "commit_rev":
"aa8e4c9b15d480285490e8343a419379a4b57889"}

[commit-bot: I haz the power, 2017-01-10 19:06:20]

Description was changed from

==========
Simplify registration of a test ChromeBrowserStateManager.

Unit test must cleanup after themselves if the register a test
ChromeBrowserStateManager with the ApplicationContext. Introduce
IOSChromeScopedTestingChromeBrowserStateManager to help with the
registration by using RAII.

BUG=None
==========

to

==========
Simplify registration of a test ChromeBrowserStateManager.

Unit test must cleanup after themselves if the register a test
ChromeBrowserStateManager with the ApplicationContext. Introduce
IOSChromeScopedTestingChromeBrowserStateManager to help with the
registration by using RAII.

BUG=None

Review-Url: https://codereview.chromium.org/2622913002
Cr-Commit-Position: refs/heads/master@{#442646}
Committed:
https://chromium.googlesource.com/chromium/src/+/aa8e4c9b15d480285490e8343a41...
==========

[commit-bot: I haz the power, 2017-01-10 19:06:21]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/aa8e4c9b15d480285490e8343a41...