[NoStatePrefetch] Don't cancel prefetches when there are duplicates

[NoStatePrefetch] Don't cancel prefetches when there are duplicates

AutocompleteActionPredictor::StartPrerendering actively destroys the existing
prerender when a new one is created, even if the new one is a duplicate.

Thus, when there is a duplicate prerender, PrerenderManager::AddPrerender
must return a handle to it, and not null. That way it increases the
reference count on the prerender and prevents it from being destroyed.

This can be done by simply changing the ordering of the existing code.

BUG=679714
Review-Url: https://codereview.chromium.org/2622893002
Cr-Commit-Position: refs/heads/master@{#442844}
Committed: https://chromium.googlesource.com/chromium/src/+/5b95a428b6dbbcdc487b23828e5637e0b69478b1

[droger, 2017-01-10 13:36:35]

Description was changed from

==========
[NoStatePrefetch] Don't cancel prefetches when there are duplicates

Autocomplete code actively destroys the existing prerender when a new
one is created, even if the new one is a duplicate.

Thus, when there is a duplicate prerender, PrerenderManager::AddPrerender
must return a handle to it, and not null. That way it increases the
reference count on the prerender and prevents it from being destroyed.

BUG=679714
==========

to

==========
[NoStatePrefetch] Don't cancel prefetches when there are duplicates

Autocomplete code actively destroys the existing prerender when a new
one is created, even if the new one is a duplicate.

Thus, when there is a duplicate prerender, PrerenderManager::AddPrerender
must return a handle to it, and not null. That way it increases the
reference count on the prerender and prevents it from being destroyed.

This can be done by simply changing the ordering of the existing code.

BUG=679714
==========

[droger, 2017-01-10 13:38:01]

Description was changed from

==========
[NoStatePrefetch] Don't cancel prefetches when there are duplicates

Autocomplete code actively destroys the existing prerender when a new
one is created, even if the new one is a duplicate.

Thus, when there is a duplicate prerender, PrerenderManager::AddPrerender
must return a handle to it, and not null. That way it increases the
reference count on the prerender and prevents it from being destroyed.

This can be done by simply changing the ordering of the existing code.

BUG=679714
==========

to

==========
[NoStatePrefetch] Don't cancel prefetches when there are duplicates

AutocompleteActionPredictor::StartPrerendering actively destroys the existing
prerender when a new one is created, even if the new one is a duplicate.

Thus, when there is a duplicate prerender, PrerenderManager::AddPrerender
must return a handle to it, and not null. That way it increases the
reference count on the prerender and prevents it from being destroyed.

This can be done by simply changing the ordering of the existing code.

BUG=679714
==========

[droger, 2017-01-10 13:49:31]

droger@chromium.org changed reviewers:
+ mattcary@chromium.org

[droger, 2017-01-10 14:58:04]

The CQ bit was checked by droger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 14:58:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mattcary, 2017-01-10 15:00:50]

lgtm

https://codereview.chromium.org/2622893002/diff/20001/chrome/browser/prerende...
File chrome/browser/prerender/prerender_unittest.cc (right):

https://codereview.chromium.org/2622893002/diff/20001/chrome/browser/prerende...
chrome/browser/prerender/prerender_unittest.cc:645: // Make sure that if queue a
request, and a second prerender request for the
Maybe say explicitly that this is the same as the previous test except for
NoState.

[droger, 2017-01-10 15:11:42]

droger@chromium.org changed reviewers:
+ lizeb@chromium.org

[droger, 2017-01-10 15:11:43]

+lizeb (because Matt is not a committer yet).

https://codereview.chromium.org/2622893002/diff/20001/chrome/browser/prerende...
File chrome/browser/prerender/prerender_unittest.cc (right):

https://codereview.chromium.org/2622893002/diff/20001/chrome/browser/prerende...
chrome/browser/prerender/prerender_unittest.cc:645: // Make sure that if queue a
request, and a second prerender request for the
On 2017/01/10 15:00:50, mattcary wrote:
> Maybe say explicitly that this is the same as the previous test except for
> NoState.

Done.

[droger, 2017-01-10 16:21:44]

The CQ bit was checked by droger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 16:22:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 17:41:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 17:41:44]

Dry run: This issue passed the CQ dry run.

[Benoit L, 2017-01-11 09:59:35]

On 2017/01/10 15:11:43, droger wrote:
> +lizeb (because Matt is not a committer yet).
> 
>
https://codereview.chromium.org/2622893002/diff/20001/chrome/browser/prerende...
> File chrome/browser/prerender/prerender_unittest.cc (right):
> 
>
https://codereview.chromium.org/2622893002/diff/20001/chrome/browser/prerende...
> chrome/browser/prerender/prerender_unittest.cc:645: // Make sure that if queue
a
> request, and a second prerender request for the
> On 2017/01/10 15:00:50, mattcary wrote:
> > Maybe say explicitly that this is the same as the previous test except for
> > NoState.
> 
> Done.

lgtm

[droger, 2017-01-11 10:00:07]

The CQ bit was checked by droger@chromium.org

[droger, 2017-01-11 10:00:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
mattcary@chromium.org
Link to the patchset: https://codereview.chromium.org/2622893002/#ps60001
(title: "format + fix test")

[commit-bot: I haz the power, 2017-01-11 10:00:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 10:16:43]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484128807398320,
"parent_rev": "bfbe566199150f86fd677871959cb0d22caeffc3", "commit_rev":
"5b95a428b6dbbcdc487b23828e5637e0b69478b1"}

[commit-bot: I haz the power, 2017-01-11 10:17:12]

Description was changed from

==========
[NoStatePrefetch] Don't cancel prefetches when there are duplicates

AutocompleteActionPredictor::StartPrerendering actively destroys the existing
prerender when a new one is created, even if the new one is a duplicate.

Thus, when there is a duplicate prerender, PrerenderManager::AddPrerender
must return a handle to it, and not null. That way it increases the
reference count on the prerender and prevents it from being destroyed.

This can be done by simply changing the ordering of the existing code.

BUG=679714
==========

to

==========
[NoStatePrefetch] Don't cancel prefetches when there are duplicates

AutocompleteActionPredictor::StartPrerendering actively destroys the existing
prerender when a new one is created, even if the new one is a duplicate.

Thus, when there is a duplicate prerender, PrerenderManager::AddPrerender
must return a handle to it, and not null. That way it increases the
reference count on the prerender and prevents it from being destroyed.

This can be done by simply changing the ordering of the existing code.

BUG=679714

Review-Url: https://codereview.chromium.org/2622893002
Cr-Commit-Position: refs/heads/master@{#442844}
Committed:
https://chromium.googlesource.com/chromium/src/+/5b95a428b6dbbcdc487b23828e56...
==========

[commit-bot: I haz the power, 2017-01-11 10:17:13]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/5b95a428b6dbbcdc487b23828e56...