Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2331)

Issue 2622873002: Remove API check for interceptors to notify us of modifying the receiver (Closed)

Created:
3 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
3 years, 11 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove API check for interceptors to notify us of modifying the receiver BUG=chromium:679345 R=verwaest@chromium.org Review-Url: https://codereview.chromium.org/2622873002 Cr-Commit-Position: refs/heads/master@{#42173} Committed: https://chromium.googlesource.com/v8/v8/+/ed43c63e26758e01631331ea820ef90baf4eb92f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -35 lines) Patch
M src/objects.cc View 3 chunks +0 lines, -35 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
jochen (gone - plz use gerrit)
3 years, 11 months ago (2017-01-10 10:27:55 UTC) #1
Toon Verwaest
lgtm. This could also just only check in case the receiver is the JSGlobalProxy since ...
3 years, 11 months ago (2017-01-10 12:20:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622873002/1
3 years, 11 months ago (2017-01-10 12:20:47 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 12:22:27 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/ed43c63e26758e01631331ea820ef90baf4...

Powered by Google App Engine
This is Rietveld 408576698