Record chrome module information

Record chrome module information

The intent is to store the chrome module's information as early as possible so it's always present in the stability debug data. For information about other modules, see https://chromiumcodereview.appspot.com/2566983009/

BUG=620813
Review-Url: https://codereview.chromium.org/2622863004
Cr-Commit-Position: refs/heads/master@{#442966}
Committed: https://chromium.googlesource.com/chromium/src/+/0e26bb04377df55aab5a2f4f5c869898d2c2cf01

[manzagop (departed), 2017-01-10 19:20:15]

manzagop@chromium.org changed reviewers:
+ bcwhite@chromium.org

[manzagop (departed), 2017-01-10 19:20:15]

Hi Brian,
Here's a quick solution to get chrome's module information. Tell me what you
think,
Pierre

[manzagop (departed), 2017-01-10 19:20:28]

The CQ bit was checked by manzagop@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 19:20:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 20:51:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 20:51:37]

Dry run: This issue passed the CQ dry run.

[Sigurður Ásgeirsson, 2017-01-10 21:32:29]

siggi@chromium.org changed reviewers:
+ siggi@chromium.org

[Sigurður Ásgeirsson, 2017-01-10 21:32:30]

nice - lgtm with that one nit.

https://codereview.chromium.org/2622863004/diff/1/chrome/browser/chrome_brows...
File chrome/browser/chrome_browser_field_trials_desktop.cc (right):

https://codereview.chromium.org/2622863004/diff/1/chrome/browser/chrome_brows...
chrome/browser/chrome_browser_field_trials_desktop.cc:152: if (headers) {
this can never be NULL. Sane to CHECK or DCHECK, but really shouldn't be tested.

[manzagop (departed), 2017-01-11 14:51:56]

The CQ bit was checked by manzagop@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 14:52:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[manzagop (departed), 2017-01-11 14:52:47]

Addressed comment, thanks!

https://codereview.chromium.org/2622863004/diff/1/chrome/browser/chrome_brows...
File chrome/browser/chrome_browser_field_trials_desktop.cc (right):

https://codereview.chromium.org/2622863004/diff/1/chrome/browser/chrome_brows...
chrome/browser/chrome_browser_field_trials_desktop.cc:152: if (headers) {
On 2017/01/10 21:32:30, Sigurður Ásgeirsson wrote:
> this can never be NULL. Sane to CHECK or DCHECK, but really shouldn't be
tested.

Done.

[manzagop (departed), 2017-01-11 14:53:30]

manzagop@chromium.org changed reviewers:
+ rkaplow@chromium.org

[manzagop (departed), 2017-01-11 14:53:31]

Hi Rob!

Could you have an OWNERS' look at chrome_browser_field_trials_desktop.cc ?

Thanks,

Pierre

[manzagop (departed), 2017-01-11 14:55:45]

Description was changed from

==========
Record chrome module information

BUG=620813
==========

to

==========
Record chrome module information

The intent is to store the chrome module's information as early as possible so
it's always present in the stability debug data. For information about other
modules, see https://chromiumcodereview.appspot.com/2566983009/

BUG=620813
==========

[commit-bot: I haz the power, 2017-01-11 15:47:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 15:47:03]

Dry run: This issue passed the CQ dry run.

[rkaplow, 2017-01-11 18:22:32]

lgtm

[manzagop (departed), 2017-01-11 18:44:40]

Thanks!

[manzagop (departed), 2017-01-11 18:44:51]

The CQ bit was checked by manzagop@chromium.org

[manzagop (departed), 2017-01-11 18:44:52]

The patchset sent to the CQ was uploaded after l-g-t-m from siggi@chromium.org
Link to the patchset: https://codereview.chromium.org/2622863004/#ps20001
(title: "Address siggi's comments")

[commit-bot: I haz the power, 2017-01-11 18:45:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 18:49:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484160291884160,
"parent_rev": "0c8f272908a7a7ea0583d7b5768740d42b790457", "commit_rev":
"0e26bb04377df55aab5a2f4f5c869898d2c2cf01"}

[commit-bot: I haz the power, 2017-01-11 18:50:13]

Description was changed from

==========
Record chrome module information

The intent is to store the chrome module's information as early as possible so
it's always present in the stability debug data. For information about other
modules, see https://chromiumcodereview.appspot.com/2566983009/

BUG=620813
==========

to

==========
Record chrome module information

The intent is to store the chrome module's information as early as possible so
it's always present in the stability debug data. For information about other
modules, see https://chromiumcodereview.appspot.com/2566983009/

BUG=620813

Review-Url: https://codereview.chromium.org/2622863004
Cr-Commit-Position: refs/heads/master@{#442966}
Committed:
https://chromium.googlesource.com/chromium/src/+/0e26bb04377df55aab5a2f4f5c86...
==========

[commit-bot: I haz the power, 2017-01-11 18:50:15]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0e26bb04377df55aab5a2f4f5c86...