Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 2622853002: Check if a deleted profile still exists before logging that it is still there (Closed)

Created:
3 years, 11 months ago by dullweber
Modified:
3 years, 11 months ago
Reviewers:
anthonyvd
CC:
chromium-reviews, rginda+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

A method that checks if files of deleted profiles still exist was added in http://crrev.com/2546523003. We decided that it is ok to call NukeProfileFromDisk without checking if the files still exist because it fails silently. But we also show a log message that says that there are still files. This cl adds a condition to check if profile files still exist to avoid showing the wrong log message. BUG=236244 Review-Url: https://codereview.chromium.org/2622853002 Cr-Commit-Position: refs/heads/master@{#442869} Committed: https://chromium.googlesource.com/chromium/src/+/dddbf3dfa410003fd7af45513a488ac523ac660d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M chrome/browser/profiles/profile_manager.cc View 1 chunk +12 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
dullweber
Hi anthony, please review this small fix for my previous cl.
3 years, 11 months ago (2017-01-10 09:20:24 UTC) #3
anthonyvd
lgtm
3 years, 11 months ago (2017-01-10 20:38:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622853002/1
3 years, 11 months ago (2017-01-11 09:11:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/97963)
3 years, 11 months ago (2017-01-11 10:24:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622853002/1
3 years, 11 months ago (2017-01-11 10:55:14 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 11:19:52 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dddbf3dfa410003fd7af45513a48...

Powered by Google App Engine
This is Rietveld 408576698