Clean-up: media::PipelineMetadata stores the rotated video size.

Clean-up: media::PipelineMetadata stores the rotated video size.

media::PipelineMetadata::natural_size could be either the orignal
video natural size or the rotated one when VideoRotation indicates a
90 degree rotation. To avoid confusion, this Cl let it always store
the video natural size after rotation.

BUG=679574
Review-Url: https://codereview.chromium.org/2622803002
Cr-Commit-Position: refs/heads/master@{#443076}
Committed: https://chromium.googlesource.com/chromium/src/+/15b483f7dc564d1aaf60e8c400b03cf78ab2f7d5

[xjz, 2017-01-10 01:12:29]

The CQ bit was checked by xjz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 01:13:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xjz, 2017-01-10 01:46:24]

Description was changed from

==========
Clean-up: media::PipelineMetadata stores the rotated video size.

media::PipelineMetadata::natural_size could be either the orignal
video natural size or the rotated one when VideoRotation indicates a
90 degree rotation. To avoid confusion, this Cl let it always store
the video natural size after rotation.

BUG=
==========

to

==========
Clean-up: media::PipelineMetadata stores the rotated video size.

media::PipelineMetadata::natural_size could be either the orignal
video natural size or the rotated one when VideoRotation indicates a
90 degree rotation. To avoid confusion, this Cl let it always store
the video natural size after rotation.

BUG=679574
==========

[xjz, 2017-01-10 01:46:24]

xjz@chromium.org changed reviewers:
+ sandersd@chromium.org

[xjz, 2017-01-10 01:48:03]

sandersd@: As commented in another CL, now let PipelineMetadata::natural_size
consistently be the rotated video size. PTAL. Thanks!

[commit-bot: I haz the power, 2017-01-10 03:16:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 03:16:20]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[miu, 2017-01-10 04:31:02]

miu@chromium.org changed reviewers:
+ miu@chromium.org

[miu, 2017-01-10 04:31:03]

lgtm % one "maybe":

https://codereview.chromium.org/2622803002/diff/1/media/blink/webmediaplayer_...
File media/blink/webmediaplayer_impl.cc (right):

https://codereview.chromium.org/2622803002/diff/1/media/blink/webmediaplayer_...
media/blink/webmediaplayer_impl.cc:1308:
GetRotatedVideoSize(pipeline_metadata_.video_rotation, size);
Sanity-check: Is this call to GetRotatedVideoSize() still needed?

https://codereview.chromium.org/2622803002/diff/1/media/remoting/remoting_ren...
File media/remoting/remoting_renderer_controller.cc (left):

https://codereview.chromium.org/2622803002/diff/1/media/remoting/remoting_ren...
media/remoting/remoting_renderer_controller.cc:16: gfx::Size
GetRotatedVideoSize(VideoRotation rotation, gfx::Size natural_size) {
Nice! :) It never felt right to me to have this function in this module.

[xjz, 2017-01-10 18:58:35]

Thanks miu@ for your reviewing!

https://codereview.chromium.org/2622803002/diff/1/media/blink/webmediaplayer_...
File media/blink/webmediaplayer_impl.cc (right):

https://codereview.chromium.org/2622803002/diff/1/media/blink/webmediaplayer_...
media/blink/webmediaplayer_impl.cc:1308:
GetRotatedVideoSize(pipeline_metadata_.video_rotation, size);
On 2017/01/10 04:31:02, miu wrote:
> Sanity-check: Is this call to GetRotatedVideoSize() still needed?

Yes, this is still needed. The input size is from the decoded video frame, which
is the original natural size.

[sandersd (OOO until July 31), 2017-01-10 19:27:56]

lgtm

https://codereview.chromium.org/2622803002/diff/1/media/blink/webmediaplayer_...
File media/blink/webmediaplayer_impl.cc (right):

https://codereview.chromium.org/2622803002/diff/1/media/blink/webmediaplayer_...
media/blink/webmediaplayer_impl.cc:1308:
GetRotatedVideoSize(pipeline_metadata_.video_rotation, size);
On 2017/01/10 18:58:35, xjz wrote:
> On 2017/01/10 04:31:02, miu wrote:
> > Sanity-check: Is this call to GetRotatedVideoSize() still needed?
> 
> Yes, this is still needed. The input size is from the decoded video frame,
which
> is the original natural size. 

Please add a comment explaining this.

[xjz, 2017-01-11 22:39:23]

Addressed comments. Thanks for reviewing!

https://codereview.chromium.org/2622803002/diff/1/media/blink/webmediaplayer_...
File media/blink/webmediaplayer_impl.cc (right):

https://codereview.chromium.org/2622803002/diff/1/media/blink/webmediaplayer_...
media/blink/webmediaplayer_impl.cc:1308:
GetRotatedVideoSize(pipeline_metadata_.video_rotation, size);
On 2017/01/10 19:27:56, sandersd wrote:
> On 2017/01/10 18:58:35, xjz wrote:
> > On 2017/01/10 04:31:02, miu wrote:
> > > Sanity-check: Is this call to GetRotatedVideoSize() still needed?
> > 
> > Yes, this is still needed. The input size is from the decoded video frame,
> which
> > is the original natural size. 
> 
> Please add a comment explaining this.

Done.

[xjz, 2017-01-11 22:39:29]

The CQ bit was checked by xjz@chromium.org

[xjz, 2017-01-11 22:39:30]

The patchset sent to the CQ was uploaded after l-g-t-m from miu@chromium.org,
sandersd@chromium.org
Link to the patchset: https://codereview.chromium.org/2622803002/#ps20001
(title: "Addressed comments.")

[commit-bot: I haz the power, 2017-01-11 22:41:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 00:21:40]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484174369519460,
"parent_rev": "d1307068024c943814b1a8da9013c25b13892f70", "commit_rev":
"15b483f7dc564d1aaf60e8c400b03cf78ab2f7d5"}

[commit-bot: I haz the power, 2017-01-12 00:22:11]

Description was changed from

==========
Clean-up: media::PipelineMetadata stores the rotated video size.

media::PipelineMetadata::natural_size could be either the orignal
video natural size or the rotated one when VideoRotation indicates a
90 degree rotation. To avoid confusion, this Cl let it always store
the video natural size after rotation.

BUG=679574
==========

to

==========
Clean-up: media::PipelineMetadata stores the rotated video size.

media::PipelineMetadata::natural_size could be either the orignal
video natural size or the rotated one when VideoRotation indicates a
90 degree rotation. To avoid confusion, this Cl let it always store
the video natural size after rotation.

BUG=679574

Review-Url: https://codereview.chromium.org/2622803002
Cr-Commit-Position: refs/heads/master@{#443076}
Committed:
https://chromium.googlesource.com/chromium/src/+/15b483f7dc564d1aaf60e8c400b0...
==========

[commit-bot: I haz the power, 2017-01-12 00:22:12]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/15b483f7dc564d1aaf60e8c400b0...