Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 2622773003: headless: Allow both WW,HH and WWxHH forms for specifying window size (Closed)

Created:
3 years, 11 months ago by Sami
Modified:
3 years, 11 months ago
Reviewers:
Eric Seckler
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

headless: Allow both WW,HH and WWxHH forms for specifying window size As Chrome only supports the former format, change the documentation to refer to that. BUG=678539 Review-Url: https://codereview.chromium.org/2622773003 Cr-Commit-Position: refs/heads/master@{#442609} Committed: https://chromium.googlesource.com/chromium/src/+/caa5c484578fa649c62a44e90a08f921eae03e96

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M headless/app/headless_shell.cc View 1 chunk +1 line, -1 line 0 comments Download
M headless/app/headless_shell_switches.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
Sami
3 years, 11 months ago (2017-01-10 15:31:49 UTC) #3
Eric Seckler
lgtm
3 years, 11 months ago (2017-01-10 15:38:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622773003/1
3 years, 11 months ago (2017-01-10 15:58:58 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 16:28:48 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/caa5c484578fa649c62a44e90a08...

Powered by Google App Engine
This is Rietveld 408576698