Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: components/safe_browsing_db/android/java/src/org/chromium/components/safe_browsing/SafeBrowsingApiHandler.java

Issue 2622773002: Componentize SafeBrowsingApi{Bridge,Handler} (Closed)
Patch Set: Addressing vakh@'s comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing_db/android/java/src/org/chromium/components/safe_browsing/SafeBrowsingApiHandler.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/safe_browsing/SafeBrowsingApiHandler.java b/components/safe_browsing_db/android/java/src/org/chromium/components/safe_browsing/SafeBrowsingApiHandler.java
similarity index 85%
rename from chrome/android/java/src/org/chromium/chrome/browser/safe_browsing/SafeBrowsingApiHandler.java
rename to components/safe_browsing_db/android/java/src/org/chromium/components/safe_browsing/SafeBrowsingApiHandler.java
index 69099461515f633aa5ad15c55e90966f0af6cb1b..7a3f656e5732d30adf928ddac289a5f738f93e52 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/safe_browsing/SafeBrowsingApiHandler.java
+++ b/components/safe_browsing_db/android/java/src/org/chromium/components/safe_browsing/SafeBrowsingApiHandler.java
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-package org.chromium.chrome.browser.safe_browsing;
+package org.chromium.components.safe_browsing;
import android.content.Context;
import android.support.annotation.IntDef;
@@ -11,8 +11,8 @@ import java.lang.annotation.Retention;
import java.lang.annotation.RetentionPolicy;
/**
- * Java interface that a SafeBrowsingApiHander must implement when used with
- * {@code SafeBrowsignApiBridge}
+ * Java interface that a SafeBrowsingApiHandler must implement when used with
+ * {@code SafeBrowsingApiBridge}
*/
public interface SafeBrowsingApiHandler {
// Implementors must provide a no-arg constructor to be instantiated via reflection.
@@ -26,17 +26,12 @@ public interface SafeBrowsingApiHandler {
// Possible values for resultStatus. Native side has the same definitions.
@Retention(RetentionPolicy.SOURCE)
- @IntDef({
- STATUS_INTERNAL_ERROR,
- STATUS_SUCCESS,
- STATUS_TIMEOUT
- })
+ @IntDef({STATUS_INTERNAL_ERROR, STATUS_SUCCESS, STATUS_TIMEOUT})
@interface SafeBrowsingResult {}
static final int STATUS_INTERNAL_ERROR = -1;
static final int STATUS_SUCCESS = 0;
static final int STATUS_TIMEOUT = 1;
-
/**
* Verifies that SafeBrowsingApiHandler can operate and initializes if feasible.
* Should be called on IO thread.

Powered by Google App Engine
This is Rietveld 408576698