components/safe_browsing_db/android/java/src/org/chromium/components/safe_browsing/SafeBrowsingApiBridge.java - Issue 2622773002: Componentize SafeBrowsingApi{Bridge,Handler}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/safe_browsing_db/android/java/src/org/chromium/components/safe_browsing/SafeBrowsingApiBridge.java

Issue 2622773002: Componentize SafeBrowsingApi{Bridge,Handler} (Closed)

Patch Set: Addressing vakh@'s comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/safe_browsing_db/android/BUILD.gn ('k') | components/safe_browsing_db/android/java/src/org/chromium/components/safe_browsing/SafeBrowsingApiHandler.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/safe_browsing_db/android/java/src/org/chromium/components/safe_browsing/SafeBrowsingApiBridge.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/safe_browsing/SafeBrowsingApiBridge.java b/components/safe_browsing_db/android/java/src/org/chromium/components/safe_browsing/SafeBrowsingApiBridge.java

similarity index 89%

rename from chrome/android/java/src/org/chromium/chrome/browser/safe_browsing/SafeBrowsingApiBridge.java

rename to components/safe_browsing_db/android/java/src/org/chromium/components/safe_browsing/SafeBrowsingApiBridge.java

index cd4668aef2735b4dd95d332832426bf2d20c43f1..a06bd1501513005aa0a74d5704fcbd78a891f165 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/safe_browsing/SafeBrowsingApiBridge.java

+++ b/components/safe_browsing_db/android/java/src/org/chromium/components/safe_browsing/SafeBrowsingApiBridge.java

@@ -2,7 +2,7 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-package org.chromium.chrome.browser.safe_browsing;

+package org.chromium.components.safe_browsing;

import android.content.Context;

@@ -15,7 +15,7 @@ import org.chromium.base.annotations.JNINamespace;

@JNINamespace("safe_browsing")

public final class SafeBrowsingApiBridge {

- private static final String TAG = "SafeBrowsingApi";

+ private static final String TAG = "ApiBridge";

private static Class<? extends SafeBrowsingApiHandler> sHandler;

@@ -56,8 +56,8 @@ public final class SafeBrowsingApiBridge {

}

@CalledByNative

- private static void startUriLookup(SafeBrowsingApiHandler handler, long callbackId,

- String uri, int[] threatsOfInterest) {

+ private static void startUriLookup(

+ SafeBrowsingApiHandler handler, long callbackId, String uri, int[] threatsOfInterest) {

handler.startUriLookup(callbackId, uri, threatsOfInterest);

Log.d(TAG, "Done starting request");

}