Remove bottom bar from Physical Web Activity

Remove bottom bar from Physical Web Activity

The bottom bar was used to let users know they would receive
notifications from the Physical Web.  Now that we don't fire
notifications, we should remove this bottom bar.

BUG=679363
Review-Url: https://codereview.chromium.org/2622743002
Cr-Commit-Position: refs/heads/master@{#443089}
Committed: https://chromium.googlesource.com/chromium/src/+/07068a979591d47d23299eec9b82f099d6ac460e

[cco3, 2017-01-09 22:37:23]

cco3@chromium.org changed reviewers:
+ mattreynolds@chromium.org

[mattreynolds, 2017-01-10 01:01:30]

https://codereview.chromium.org/2622743002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java
(right):

https://codereview.chromium.org/2622743002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java:75:
initSharedPreferences();
Can we remove the rest of the SharedPreferences logic in this class? I don't
think it's used for anything other than the bottom bar.

[cco3, 2017-01-10 01:18:02]

https://codereview.chromium.org/2622743002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java
(right):

https://codereview.chromium.org/2622743002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java:75:
initSharedPreferences();
On 2017/01/10 01:01:30, mattreynolds wrote:
> Can we remove the rest of the SharedPreferences logic in this class? I don't
> think it's used for anything other than the bottom bar.

Done.

[mattreynolds, 2017-01-10 01:26:07]

lgtm

[cco3, 2017-01-10 01:27:47]

cco3@chromium.org changed reviewers:
+ nyquist@chromium.org

[cco3, 2017-01-10 01:27:47]

Hi Tommy, would you be available to review this cleanup change?

[nyquist, 2017-01-11 18:47:57]

lgtm, but are you sure you want to remove the version field? It's fine with me.
The less fields the better.

[cco3, 2017-01-11 19:28:26]

On 2017/01/11 18:47:57, nyquist wrote:
> lgtm, but are you sure you want to remove the version field? It's fine with
me.
> The less fields the better.

Yes, there should be no need to store anything associated with the Activity. 
The hope is to get rid of this activity in another release.

[cco3, 2017-01-11 19:29:27]

cco3@chromium.org changed reviewers:
+ yusufo@chromium.org

[cco3, 2017-01-11 19:29:28]

Hi Yusuf, would you be able to review this xml change?

[Yusuf, 2017-01-11 19:31:18]

lgtm

[cco3, 2017-01-11 19:32:30]

Thanks!

[cco3, 2017-01-11 19:32:35]

The CQ bit was checked by cco3@chromium.org

[commit-bot: I haz the power, 2017-01-11 19:33:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 19:53:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 19:53:11]

Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[cco3, 2017-01-11 23:18:01]

The CQ bit was checked by cco3@chromium.org

[cco3, 2017-01-11 23:18:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
nyquist@chromium.org, yusufo@chromium.org, mattreynolds@chromium.org
Link to the patchset: https://codereview.chromium.org/2622743002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-01-11 23:19:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 00:44:19]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484176681217190,
"parent_rev": "914245e19d7a89a64f2d61b0e4388161635cae20", "commit_rev":
"07068a979591d47d23299eec9b82f099d6ac460e"}

[commit-bot: I haz the power, 2017-01-12 00:45:24]

Description was changed from

==========
Remove bottom bar from Physical Web Activity

The bottom bar was used to let users know they would receive
notifications from the Physical Web.  Now that we don't fire
notifications, we should remove this bottom bar.

BUG=679363
==========

to

==========
Remove bottom bar from Physical Web Activity

The bottom bar was used to let users know they would receive
notifications from the Physical Web.  Now that we don't fire
notifications, we should remove this bottom bar.

BUG=679363

Review-Url: https://codereview.chromium.org/2622743002
Cr-Commit-Position: refs/heads/master@{#443089}
Committed:
https://chromium.googlesource.com/chromium/src/+/07068a979591d47d23299eec9b82...
==========

[commit-bot: I haz the power, 2017-01-12 00:45:26]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/07068a979591d47d23299eec9b82...