Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 2622713002: Remove bitmap_platform_device_skia (Closed)

Created:
3 years, 11 months ago by f(malita)
Modified:
3 years, 11 months ago
Reviewers:
robertphillips1, reed1
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove bitmap_platform_device_skia It is now a no-op SkBitmapDevice wrapper. Just use a bitmap-backed canvas for non-Win platforms. BUG=675977 R=reed@google.com,robertphillips@chromium.org TBR= Review-Url: https://codereview.chromium.org/2622713002 Cr-Commit-Position: refs/heads/master@{#442591} Committed: https://chromium.googlesource.com/chromium/src/+/577ac190cc7cbb727dec0c5ead7941ac22815935

Patch Set 1 #

Patch Set 2 : s/0/nullptr/ #

Patch Set 3 : missing snapshot_aura_unittest.cc include #

Patch Set 4 : missing MakeUnique Win header #

Patch Set 5 : Win build fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -144 lines) Patch
M skia/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D skia/ext/bitmap_platform_device_skia.h View 1 chunk +0 lines, -58 lines 0 comments Download
D skia/ext/bitmap_platform_device_skia.cc View 1 chunk +0 lines, -64 lines 0 comments Download
M skia/ext/bitmap_platform_device_win.cc View 1 2 3 4 2 chunks +9 lines, -2 lines 0 comments Download
M skia/ext/platform_canvas.h View 1 3 chunks +4 lines, -8 lines 0 comments Download
M skia/ext/platform_canvas.cc View 2 chunks +33 lines, -10 lines 0 comments Download
M ui/snapshot/snapshot_aura_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 27 (18 generated)
f(malita)
3 years, 11 months ago (2017-01-09 21:38:49 UTC) #3
robertphillips1
lgtm
3 years, 11 months ago (2017-01-09 21:44:12 UTC) #5
reed1
dang, that is a pretty cl (lots of deletes) lgtm
3 years, 11 months ago (2017-01-09 21:48:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622713002/20001
3 years, 11 months ago (2017-01-09 21:50:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622713002/40001
3 years, 11 months ago (2017-01-09 22:04:25 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622713002/60001
3 years, 11 months ago (2017-01-09 22:23:47 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/360353) win_clang on master.tryserver.chromium.win (JOB_FAILED, ...
3 years, 11 months ago (2017-01-09 23:14:41 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622713002/80001
3 years, 11 months ago (2017-01-10 14:27:46 UTC) #24
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 15:33:44 UTC) #27
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/577ac190cc7cbb727dec0c5ead79...

Powered by Google App Engine
This is Rietveld 408576698