NetworkQualityEstimator: Enable prefs writing by default

NetworkQualityEstimator: Enable prefs writing by default

Enable writing to the prefs by default in the network quality estimator 
(NQE). The reading from the prefs is still disable by default, and 
controlled via field trial.

Also enable correlation logging by default which records UMA on 
correlation between a higher layer metric, and a lower layer metric.

Also, use UMA_HISTPGRAM_EXACT_LINEAR for 2 histograms since those 
histograms only need 2 buckets for storing data.

BUG=490870
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2622663002
Cr-Commit-Position: refs/heads/master@{#443025}
Committed: https://chromium.googlesource.com/chromium/src/+/829fa5d5abc060c3fca83c2324bb8ce47a43361c

[tbansal1, 2017-01-09 18:17:36]

Description was changed from

==========
Enable cache writing by default

BUG=
==========

to

==========
Enable cache writing by default

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[tbansal1, 2017-01-09 18:19:00]

Description was changed from

==========
Enable cache writing by default

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Enable cache writing by default

Enable writing to the cache by default in network quality estimator. Also
enable correlation logging by default.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[tbansal1, 2017-01-09 18:26:07]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 18:26:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbansal1, 2017-01-09 18:27:42]

Description was changed from

==========
Enable cache writing by default

Enable writing to the cache by default in network quality estimator. Also
enable correlation logging by default.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
NetworkQualityEstimator: Enable prefs writing by default

Enable writing to the prefs by default in the network quality estimator 
(NQE). The reading from the prefs is still disable by default, and 
controlled via field trial.

Also enable correlation logging by default which records UMA on 
correlation between a higher layer metric, and a lower layer metric.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[tbansal1, 2017-01-09 18:42:12]

Patchset #1 (id:1) has been deleted

[tbansal1, 2017-01-09 18:42:43]

Description was changed from

==========
NetworkQualityEstimator: Enable prefs writing by default

Enable writing to the prefs by default in the network quality estimator 
(NQE). The reading from the prefs is still disable by default, and 
controlled via field trial.

Also enable correlation logging by default which records UMA on 
correlation between a higher layer metric, and a lower layer metric.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
NetworkQualityEstimator: Enable prefs writing by default

Enable writing to the prefs by default in the network quality estimator 
(NQE). The reading from the prefs is still disable by default, and 
controlled via field trial.

Also enable correlation logging by default which records UMA on 
correlation between a higher layer metric, and a lower layer metric.

Also, use UMA_HISTPGRAM_EXACT_LINEAR for 2 histograms since those 
histograms only need 2 buckets for storing data.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[tbansal1, 2017-01-09 18:43:00]

Description was changed from

==========
NetworkQualityEstimator: Enable prefs writing by default

Enable writing to the prefs by default in the network quality estimator 
(NQE). The reading from the prefs is still disable by default, and 
controlled via field trial.

Also enable correlation logging by default which records UMA on 
correlation between a higher layer metric, and a lower layer metric.

Also, use UMA_HISTPGRAM_EXACT_LINEAR for 2 histograms since those 
histograms only need 2 buckets for storing data.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
NetworkQualityEstimator: Enable prefs writing by default

Enable writing to the prefs by default in the network quality estimator 
(NQE). The reading from the prefs is still disable by default, and 
controlled via field trial.

Also enable correlation logging by default which records UMA on 
correlation between a higher layer metric, and a lower layer metric.

Also, use UMA_HISTPGRAM_EXACT_LINEAR for 2 histograms since those 
histograms only need 2 buckets for storing data.

BUG=490870
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[tbansal1, 2017-01-09 18:43:19]

tbansal@chromium.org changed reviewers:
+ ryansturm@chromium.org

[tbansal1, 2017-01-09 18:43:20]

ryansturm: ptal. thanks.

[tbansal1, 2017-01-09 18:43:35]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 18:43:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[RyanSturm, 2017-01-09 18:59:50]

lgtm

[tbansal1, 2017-01-09 19:06:44]

tbansal@chromium.org changed reviewers:
+ bengr@chromium.org

[tbansal1, 2017-01-09 19:06:44]

bengr: ptal. Thanks.

[commit-bot: I haz the power, 2017-01-09 19:08:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 19:08:21]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[tbansal1, 2017-01-09 19:20:26]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 19:21:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 19:48:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 19:48:59]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[tbansal1, 2017-01-10 00:44:58]

Patchset #2 (id:40001) has been deleted

[tbansal1, 2017-01-10 00:45:17]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 00:45:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 02:47:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 02:47:58]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)

[tbansal1, 2017-01-11 00:04:39]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[tbansal1, 2017-01-11 00:04:42]

Patchset #2 (id:60001) has been deleted

[commit-bot: I haz the power, 2017-01-11 00:05:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 01:27:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 01:27:45]

Dry run: This issue passed the CQ dry run.

[bengr, 2017-01-11 22:15:15]

lgtm

[tbansal1, 2017-01-11 22:27:15]

The CQ bit was checked by tbansal@chromium.org

[tbansal1, 2017-01-11 22:27:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
ryansturm@chromium.org
Link to the patchset: https://codereview.chromium.org/2622663002/#ps80001
(title: "Fix moar tests")

[commit-bot: I haz the power, 2017-01-11 22:29:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 22:43:06]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1484173635149950,
"parent_rev": "e41b7310e119afeb16eb76a10af9a67098e60bda", "commit_rev":
"829fa5d5abc060c3fca83c2324bb8ce47a43361c"}

[commit-bot: I haz the power, 2017-01-11 22:43:48]

Description was changed from

==========
NetworkQualityEstimator: Enable prefs writing by default

Enable writing to the prefs by default in the network quality estimator 
(NQE). The reading from the prefs is still disable by default, and 
controlled via field trial.

Also enable correlation logging by default which records UMA on 
correlation between a higher layer metric, and a lower layer metric.

Also, use UMA_HISTPGRAM_EXACT_LINEAR for 2 histograms since those 
histograms only need 2 buckets for storing data.

BUG=490870
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
NetworkQualityEstimator: Enable prefs writing by default

Enable writing to the prefs by default in the network quality estimator 
(NQE). The reading from the prefs is still disable by default, and 
controlled via field trial.

Also enable correlation logging by default which records UMA on 
correlation between a higher layer metric, and a lower layer metric.

Also, use UMA_HISTPGRAM_EXACT_LINEAR for 2 histograms since those 
histograms only need 2 buckets for storing data.

BUG=490870
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2622663002
Cr-Commit-Position: refs/heads/master@{#443025}
Committed:
https://chromium.googlesource.com/chromium/src/+/829fa5d5abc060c3fca83c2324bb...
==========

[commit-bot: I haz the power, 2017-01-11 22:43:50]

Committed patchset #2 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/829fa5d5abc060c3fca83c2324bb...