Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2622653002: [foozzie] Fix path to metadata (Closed)

Created:
3 years, 11 months ago by Michael Achenbach
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[foozzie] Fix path to metadata This makes sure the metadata is found during minimization. Also renames the test files to fit the naming pattern. BUG=chromium:673246 NOTRY=true TBR=tandrii@chromium.org,mbarbella@chromium.org Review-Url: https://codereview.chromium.org/2622653002 Cr-Commit-Position: refs/heads/master@{#42150} Committed: https://chromium.googlesource.com/v8/v8/+/6d82e6182b765f5111724908d0579ea84a5141ea

Patch Set 1 #

Patch Set 2 : presubmit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
A + tools/foozzie/testdata/fuzz-123.js View 0 chunks +-1 lines, --1 lines 0 comments Download
D tools/foozzie/testdata/fuzz-test1.js View 1 chunk +0 lines, -5 lines 0 comments Download
A + tools/foozzie/testdata/meta-123.js View 0 chunks +-1 lines, --1 lines 0 comments Download
D tools/foozzie/testdata/meta-test1.json View 1 chunk +0 lines, -3 lines 0 comments Download
A + tools/foozzie/testdata/resources-123.js View 0 chunks +-1 lines, --1 lines 0 comments Download
D tools/foozzie/testdata/resources-test1.js View 1 chunk +0 lines, -1 line 0 comments Download
M tools/foozzie/v8_foozzie.py View 2 chunks +5 lines, -2 lines 0 comments Download
M tools/foozzie/v8_foozzie_test.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/presubmit.py View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
Michael Achenbach
TBR
3 years, 11 months ago (2017-01-09 18:02:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622653002/1
3 years, 11 months ago (2017-01-09 18:02:24 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/31877)
3 years, 11 months ago (2017-01-09 18:05:14 UTC) #6
tandrii(chromium)
lgtm
3 years, 11 months ago (2017-01-09 18:09:58 UTC) #7
Michael Achenbach
On 2017/01/09 18:09:58, tandrii(chromium) wrote: > lgtm strange - how did it ever pass presubmit?
3 years, 11 months ago (2017-01-09 18:14:50 UTC) #8
Michael Achenbach
On 2017/01/09 18:14:50, Michael Achenbach wrote: > On 2017/01/09 18:09:58, tandrii(chromium) wrote: > > lgtm ...
3 years, 11 months ago (2017-01-09 18:17:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622653002/20001
3 years, 11 months ago (2017-01-09 18:18:04 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 18:19:44 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/6d82e6182b765f5111724908d0579ea84a5...

Powered by Google App Engine
This is Rietveld 408576698