Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2622633006: [Devtools] Fixes screencast when devtools is screencasting (Closed)

Created:
3 years, 11 months ago by allada
Modified:
3 years, 11 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Fixes screencast when devtools is screencasting This patch fixed a bug when devtools is scaled it causes some backend errors to occur due to expecting an integer instead of float. R=dgozman BUG=679268 Review-Url: https://codereview.chromium.org/2622633006 Cr-Commit-Position: refs/heads/master@{#442798} Committed: https://chromium.googlesource.com/chromium/src/+/275b25d4d93d0eeb6277b3f4f24fbce319ffe1fe

Patch Set 1 #

Patch Set 2 : [Devtools] Fixes screencast when devtools is screencasting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 16 (10 generated)
allada
PTL. I can add an assertion into the protocol agent and maybe write a browser ...
3 years, 11 months ago (2017-01-10 20:13:18 UTC) #3
dgozman
lgtm I don't think we need a test. Let's instead add a comment that protocol ...
3 years, 11 months ago (2017-01-10 21:53:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622633006/20001
3 years, 11 months ago (2017-01-10 22:24:50 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/97290)
3 years, 11 months ago (2017-01-10 23:52:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622633006/20001
3 years, 11 months ago (2017-01-11 01:29:58 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 04:24:09 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/275b25d4d93d0eeb6277b3f4f24f...

Powered by Google App Engine
This is Rietveld 408576698