Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2622613002: Revert of [Mac] Flip toolbar in RTL (Closed)

Created:
3 years, 11 months ago by lgrey
Modified:
3 years, 11 months ago
Reviewers:
Nico
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, mac-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Mac] Flip toolbar in RTL (patchset #5 id:80001 of https://codereview.chromium.org/2607533004/ ) Reason for revert: Caused crbug.com/679249 Original issue's description: > [Mac] Flip toolbar in RTL > > Browser actions will be reordered in a future change. > > BUG=648558, 648563, 673362 > > Review-Url: https://codereview.chromium.org/2607533004 > Cr-Commit-Position: refs/heads/master@{#441925} > Committed: https://chromium.googlesource.com/chromium/src/+/8b0fd02afc2107ba123774e0a464a43407a108cf TBR=tapted@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=648558, 648563, 673362 Review-Url: https://codereview.chromium.org/2622613002 Cr-Commit-Position: refs/heads/master@{#442257} Committed: https://chromium.googlesource.com/chromium/src/+/d0eda8fc58bd6357bb5a18e4d977b98de988857a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -247 lines) Patch
M chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm View 5 chunks +20 lines, -36 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm View 3 chunks +6 lines, -17 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm View 18 chunks +87 lines, -118 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller_unittest.mm View 6 chunks +4 lines, -72 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
lgrey
Created Revert of [Mac] Flip toolbar in RTL
3 years, 11 months ago (2017-01-09 15:29:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622613002/1
3 years, 11 months ago (2017-01-09 15:30:10 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 11 months ago (2017-01-09 15:30:12 UTC) #5
lgrey
3 years, 11 months ago (2017-01-09 15:39:16 UTC) #7
Nico
lgtm
3 years, 11 months ago (2017-01-09 15:39:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622613002/1
3 years, 11 months ago (2017-01-09 15:40:07 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 16:11:01 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d0eda8fc58bd6357bb5a18e4d977...

Powered by Google App Engine
This is Rietveld 408576698