Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2622583002:
Push preg_parser changes upstream (Closed)
|
Created:
3 years, 11 months ago by ljusten (tachyonic) Modified:
3 years, 11 months ago Reviewers:
Thiemo Nagel CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionPush preg_parser changes upstream
preg_parser and registry_dict are used in Chromium OS by authpolicy
code to fetch policy from AD servers. Right now, a custom version of
the two files is checked into platform2 in Chromium OS. This CL
pushes changes made to these files upstream to Chromium, see CrOS
CL:416068. The goal is to eventually use them in libchrome, so that
only one version of the code has to be maintained and unit tests can
be reused.
BUG=chromium:659645
TEST=Compiled on Linux
Review-Url: https://codereview.chromium.org/2622583002
Cr-Commit-Position: refs/heads/master@{#442564}
Committed: https://chromium.googlesource.com/chromium/src/+/f601211275a7ed8a187d49099ea3c81c4168b445
Patch Set 1 #Patch Set 2 : Fixed compile error #Patch Set 3 : Changed NextChar back to int (-1 is error code) #Messages
Total messages: 25 (17 generated)
ljusten@chromium.org changed reviewers: + tnagel@chromium.org
lgtm
The CQ bit was checked by ljusten@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by ljusten@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by ljusten@chromium.org
The CQ bit was checked by ljusten@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tnagel@chromium.org Link to the patchset: https://codereview.chromium.org/2622583002/#ps20001 (title: "Fixed compile error")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
The CQ bit was checked by ljusten@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by ljusten@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tnagel@chromium.org Link to the patchset: https://codereview.chromium.org/2622583002/#ps40001 (title: "Changed NextChar back to int (-1 is error code)")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484053165813230,
"parent_rev": "c1a7078994c97ac791bdd45abec4fdce33900901", "commit_rev":
"f601211275a7ed8a187d49099ea3c81c4168b445"}
Message was sent while issue was closed.
Description was changed from ========== Push preg_parser changes upstream preg_parser and registry_dict are used in Chromium OS by authpolicy code to fetch policy from AD servers. Right now, a custom version of the two files is checked into platform2 in Chromium OS. This CL pushes changes made to these files upstream to Chromium, see CrOS CL:416068. The goal is to eventually use them in libchrome, so that only one version of the code has to be maintained and unit tests can be reused. BUG=chromium:659645 TEST=Compiled on Linux ========== to ========== Push preg_parser changes upstream preg_parser and registry_dict are used in Chromium OS by authpolicy code to fetch policy from AD servers. Right now, a custom version of the two files is checked into platform2 in Chromium OS. This CL pushes changes made to these files upstream to Chromium, see CrOS CL:416068. The goal is to eventually use them in libchrome, so that only one version of the code has to be maintained and unit tests can be reused. BUG=chromium:659645 TEST=Compiled on Linux Review-Url: https://codereview.chromium.org/2622583002 Cr-Commit-Position: refs/heads/master@{#442564} Committed: https://chromium.googlesource.com/chromium/src/+/f601211275a7ed8a187d49099ea3... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/f601211275a7ed8a187d49099ea3... |
