Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2622553002: Roll HarfBuzz to 1.4.1 (Closed)

Created:
3 years, 11 months ago by drott
Modified:
3 years, 11 months ago
Reviewers:
kojii, eae, behdad
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll HarfBuzz to 1.4.1 Includes support for specifying OpenType 1.8 font variations axis parameters. Baseline updates due to expected advance width differences for some Khmer combining marks, as well as combining marks placement in combination with ligatures, due to HarfBuzz commit 1a0f4aa6dfee69236b4. BUG=679305 Review-Url: https://codereview.chromium.org/2622553002 Cr-Commit-Position: refs/heads/master@{#444707} Committed: https://chromium.googlesource.com/chromium/src/+/f2dc38825cce54c0b87841a420afbd71453d506b

Patch Set 1 #

Patch Set 2 : Linux rebaselines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1516 lines, -536 lines) Patch
M third_party/WebKit/LayoutTests/platform/linux/fast/text/emphasis-complex-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/text/emphasis-complex-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/text/international/khmer-selection-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/text/international/khmer-selection-expected.txt View 1 1 chunk +18 lines, -18 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/text/large-text-composed-char-expected.txt View 1 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/harfbuzz-ng/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/harfbuzz-ng/NEWS View 1 chunk +44 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/README.chromium View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-coretext.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-fallback-shape.cc View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-font.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-font.cc View 4 chunks +33 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-font-private.hh View 3 chunks +10 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ft.cc View 2 chunks +18 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-glib.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-glib.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-graphite2.cc View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-open-type-private.hh View 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-font.cc View 1 chunk +5 lines, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout.h View 2 chunks +19 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout.cc View 5 chunks +39 lines, -248 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout-common-private.hh View 6 chunks +484 lines, -13 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout-gdef-table.hh View 11 chunks +34 lines, -18 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout-gpos-table.hh View 18 chunks +57 lines, -60 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout-gsub-table.hh View 12 chunks +50 lines, -32 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout-gsubgpos-private.hh View 6 chunks +33 lines, -3 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-map.cc View 4 chunks +63 lines, -48 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-map-private.hh View 3 chunks +11 lines, -7 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-ot-math.cc View 1 chunk +272 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape.cc View 15 chunks +54 lines, -16 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-arabic.cc View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-default.cc View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-hangul.cc View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-hebrew.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-indic.cc View 2 chunks +8 lines, -12 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-myanmar.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-myanmar-machine.hh View 10 chunks +19 lines, -19 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-private.hh View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-thai.cc View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-tibetan.cc View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-use.cc View 2 chunks +43 lines, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-private.hh View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-private.hh View 1 chunk +7 lines, -4 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-shape.cc View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-shape-plan.h View 1 chunk +19 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-shape-plan.cc View 13 chunks +93 lines, -9 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-shape-plan-private.hh View 1 chunk +7 lines, -2 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-unicode.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-version.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 26 (14 generated)
drott
3 years, 11 months ago (2017-01-09 12:01:27 UTC) #4
drott
Behdad, are the Khmer clustering differences expected? https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_rel_ng/366876/layout-test-results/results.html
3 years, 11 months ago (2017-01-09 13:28:59 UTC) #5
drott
There is also a small width difference with the "composed chars" test: https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_rel_ng/366889/layout-test-results/results.html Is that ...
3 years, 11 months ago (2017-01-09 14:32:42 UTC) #8
eae
LGTM
3 years, 11 months ago (2017-01-09 17:17:27 UTC) #9
behdad_google
Dominik, I'm curious what causes those two changes, but none look like a blocker. What ...
3 years, 11 months ago (2017-01-09 23:25:53 UTC) #10
eae
On 2017/01/09 23:25:53, behdad_google wrote: > Dominik, > > I'm curious what causes those two ...
3 years, 11 months ago (2017-01-10 23:21:52 UTC) #11
drott
The first Khmer difference from fast/text/international/khmer-selection.html is that KHMER SIGN MUUSIKATOAN has a non-zero advance ...
3 years, 11 months ago (2017-01-18 14:38:37 UTC) #14
drott
Bisecting the other test difference for "Af̀fiZ" identifies the exact same commit 1a0f4aa6dfee692: Before (looking ...
3 years, 11 months ago (2017-01-18 14:53:43 UTC) #15
chromium-reviews
Ok, thanks. That's expected. On Wed, Jan 18, 2017 at 6:53 AM, <drott@chromium.org> wrote: > ...
3 years, 11 months ago (2017-01-18 20:04:47 UTC) #18
drott
Linux rebaselines
3 years, 11 months ago (2017-01-19 09:12:48 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622553002/20001
3 years, 11 months ago (2017-01-19 09:14:56 UTC) #23
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 11:28:46 UTC) #26
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f2dc38825cce54c0b87841a420af...

Powered by Google App Engine
This is Rietveld 408576698