Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2622533002: Prefer ContextClient mixin over manual ExecutionContext handling. (Closed)

Created:
3 years, 11 months ago by sof
Modified:
3 years, 11 months ago
Reviewers:
haraken
CC:
chromium-reviews, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, eric.carlson_apple.com, tommyw+watchlist_chromium.org, blink-reviews, Srirama, mcasas+watch+mediastream_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prefer ContextClient mixin over manual ExecutionContext handling. The ContextClient mixin interface bundles up the safe handling of references to ExecutionContexts. Prefer using it over keeping explicit Member<ExecutionContext> references. R= BUG=610176 Review-Url: https://codereview.chromium.org/2622533002 Cr-Commit-Position: refs/heads/master@{#442250} Committed: https://chromium.googlesource.com/chromium/src/+/eb00bf41cc3f3fb7cf68ab3ecce3bff4e52f5ff6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -32 lines) Patch
M third_party/WebKit/Source/modules/mediasource/SourceBufferList.h View 4 chunks +7 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/mediasource/SourceBufferList.cpp View 3 chunks +2 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStream.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStream.cpp View 8 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationConnectionList.h View 4 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationConnectionList.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
sof
please take a look.
3 years, 11 months ago (2017-01-09 10:56:40 UTC) #4
haraken
LGTM
3 years, 11 months ago (2017-01-09 13:59:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622533002/1
3 years, 11 months ago (2017-01-09 15:05:38 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 15:09:25 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/eb00bf41cc3f3fb7cf68ab3ecce3...

Powered by Google App Engine
This is Rietveld 408576698