Add milo_service to perf dashboard.

Add milo_service to perf dashboard.

Milo allows us to query for info about builds. This will be used
to debug data stoppage alerts.

BUG=catapult:#3132

Review-Url: https://codereview.chromium.org/2622503004
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/cc4ede7dec5c85f6166b882d553fc931b65bc464

[sullivan, 2017-01-09 18:31:50]

The CQ bit was checked by sullivan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 18:31:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 18:36:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 18:36:11]

Dry run: Try jobs failed on following builders:
  Catapult Mac Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Ma...)

[sullivan, 2017-01-09 20:12:57]

The CQ bit was checked by sullivan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 20:13:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sullivan, 2017-01-09 20:13:07]

sullivan@chromium.org changed reviewers:
+ eakuefner@chromium.org

[commit-bot: I haz the power, 2017-01-09 20:33:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 20:33:02]

Dry run: This issue passed the CQ dry run.

[eakuefner, 2017-01-09 21:30:31]

lgtm

https://codereview.chromium.org/2622503004/diff/20001/dashboard/dashboard/ser...
File dashboard/dashboard/services/milo_service.py (right):

https://codereview.chromium.org/2622503004/diff/20001/dashboard/dashboard/ser...
dashboard/dashboard/services/milo_service.py:48: resp =
json.loads(response.content[5:])  # Remove the jsonp header.
Is there documentation on their jsonp format anywhere, or did you just figure it
out by inspecting responses manually? Is this built-in to grpc? I'm just asking
because this seems like it might be fragile, so the more we know about the magic
number 5, the better.

[eakuefner, 2017-01-09 21:39:02]

Also, do you have a tracking bug for this work?

[sullivan, 2017-01-09 21:56:20]

Description was changed from

==========
Add milo_service to perf dashboard.

Milo allows us to query for info about builds. This will be used
to debug data stoppage alerts.
==========

to

==========
Add milo_service to perf dashboard.

Milo allows us to query for info about builds. This will be used
to debug data stoppage alerts.

BUG=catapult:#3132
==========

[sullivan, 2017-01-09 21:56:27]

On 2017/01/09 21:39:02, eakuefner wrote:
> Also, do you have a tracking bug for this work?

Added.

[sullivan, 2017-01-09 21:57:01]

The CQ bit was checked by sullivan@chromium.org

[commit-bot: I haz the power, 2017-01-09 21:57:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sullivan, 2017-01-09 21:57:16]

https://codereview.chromium.org/2622503004/diff/20001/dashboard/dashboard/ser...
File dashboard/dashboard/services/milo_service.py (right):

https://codereview.chromium.org/2622503004/diff/20001/dashboard/dashboard/ser...
dashboard/dashboard/services/milo_service.py:48: resp =
json.loads(response.content[5:])  # Remove the jsonp header.
On 2017/01/09 21:30:31, eakuefner wrote:
> Is there documentation on their jsonp format anywhere, or did you just figure
it
> out by inspecting responses manually? Is this built-in to grpc? I'm just
asking
> because this seems like it might be fragile, so the more we know about the
magic
> number 5, the better.

I added a comment; this is a really common prefix used for security purposes.

[commit-bot: I haz the power, 2017-01-09 21:58:21]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483999021403420,
"parent_rev": "fc01d81546f33d77f30286eaaf5f96e3904a8b1d", "commit_rev":
"cc4ede7dec5c85f6166b882d553fc931b65bc464"}

[commit-bot: I haz the power, 2017-01-09 21:58:24]

Description was changed from

==========
Add milo_service to perf dashboard.

Milo allows us to query for info about builds. This will be used
to debug data stoppage alerts.

BUG=catapult:#3132
==========

to

==========
Add milo_service to perf dashboard.

Milo allows us to query for info about builds. This will be used
to debug data stoppage alerts.

BUG=catapult:#3132

Review-Url: https://codereview.chromium.org/2622503004
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-01-09 21:58:25]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...