include fixing: api.h shouldn't include objects-inl.h

include fixing: api.h shouldn't include objects-inl.h

Downside: this adds all kinds of weird includes in the .cc files.

(See design doc linked in the bug.)

BUG=v8:5402
Review-Url: https://codereview.chromium.org/2622503002
Cr-Commit-Position: refs/heads/master@{#42140}
Committed: https://chromium.googlesource.com/v8/v8/+/9c7b87269c5220c7b56574c41d37e2add9267bbd

[marja, 2017-01-09 09:31:01]

The CQ bit was checked by marja@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 09:31:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[marja, 2017-01-09 09:41:54]

The CQ bit was checked by marja@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 09:41:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 09:51:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 09:51:28]

Dry run: Try jobs failed on following builders:
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)

[marja, 2017-01-09 10:25:07]

Description was changed from

==========
Proof of concept: api.h shouldn't include objects-inl.h

Downside: this adds all kinds of weird includes in the .cc files.

v8:5402

BUG=
==========

to

==========
include fixing: api.h shouldn't include objects-inl.h

Downside: this adds all kinds of weird includes in the .cc files.

(See design doc linked in the bug.)

BUG=v8:5402
==========

[marja, 2017-01-09 10:25:07]

marja@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[marja, 2017-01-09 10:28:38]

ptal

[Yang, 2017-01-09 10:35:12]

On 2017/01/09 10:28:38, marja wrote:
> ptal

src/snapshot and src/regexp lgtm.

[Michael Starzinger, 2017-01-09 11:33:07]

Looking good, just one question.

https://codereview.chromium.org/2622503002/diff/80001/src/handles.h
File src/handles.h (right):

https://codereview.chromium.org/2622503002/diff/80001/src/handles.h#newcode95
src/handles.h:95: DCHECK(T::IsObjectSubclass());
Are we allowed to use std::is_base_of (https://chromium-cpp.appspot.com/ says
everything in <type_traits> is allowed)? I have the feeling this could be
expressed as a static assert in that case. WDYT? I am thinking along the lines
of ...

static_assert(std::is_base_of<Object, T>::value, "static type violation");

[marja, 2017-01-09 11:48:06]

The CQ bit was checked by marja@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 11:48:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[marja, 2017-01-09 11:48:36]

https://codereview.chromium.org/2622503002/diff/80001/src/handles.h
File src/handles.h (right):

https://codereview.chromium.org/2622503002/diff/80001/src/handles.h#newcode95
src/handles.h:95: DCHECK(T::IsObjectSubclass());
On 2017/01/09 11:33:07, Michael Starzinger wrote:
> Are we allowed to use std::is_base_of (https://chromium-cpp.appspot.com/ says
> everything in <type_traits> is allowed)? I have the feeling this could be
> expressed as a static assert in that case. WDYT? I am thinking along the lines
> of ...
> 
> static_assert(std::is_base_of<Object, T>::value, "static type violation");

Done.

[Michael Starzinger, 2017-01-09 11:50:20]

LGTM.

[marja, 2017-01-09 11:50:44]

The CQ bit was unchecked by marja@chromium.org

[marja, 2017-01-09 11:50:51]

The CQ bit was checked by marja@chromium.org

[marja, 2017-01-09 11:50:51]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2622503002/#ps100001
(title: "static type check")

[commit-bot: I haz the power, 2017-01-09 11:50:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 11:54:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 11:54:23]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/31835)

[marja, 2017-01-09 11:56:13]

marja@chromium.org changed reviewers:
+ bmeurer@chromium.org, titzer@chromium.org

[marja, 2017-01-09 11:56:14]

bmeurer, titzer, ptal, you're owners of the following:

bmeurer: src/crankshaft/
titzer: test/cctest/asmjs/

[titzer, 2017-01-09 12:18:03]

On 2017/01/09 11:56:14, marja wrote:
> bmeurer, titzer, ptal, you're owners of the following:
> 
> bmeurer: src/crankshaft/
> titzer: test/cctest/asmjs/

LGTM

[Benedikt Meurer, 2017-01-09 12:49:42]

LGTM!

[marja, 2017-01-09 12:57:03]

The CQ bit was checked by marja@chromium.org

[commit-bot: I haz the power, 2017-01-09 12:57:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 13:43:29]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1483966623272320,
"parent_rev": "7256d90a35faf5d8cf52773fca06e6ad7a1e1ba4", "commit_rev":
"9c7b87269c5220c7b56574c41d37e2add9267bbd"}

[commit-bot: I haz the power, 2017-01-09 13:43:33]

Description was changed from

==========
include fixing: api.h shouldn't include objects-inl.h

Downside: this adds all kinds of weird includes in the .cc files.

(See design doc linked in the bug.)

BUG=v8:5402
==========

to

==========
include fixing: api.h shouldn't include objects-inl.h

Downside: this adds all kinds of weird includes in the .cc files.

(See design doc linked in the bug.)

BUG=v8:5402

Review-Url: https://codereview.chromium.org/2622503002
Cr-Commit-Position: refs/heads/master@{#42140}
Committed:
https://chromium.googlesource.com/v8/v8/+/9c7b87269c5220c7b56574c41d37e2add92...
==========

[commit-bot: I haz the power, 2017-01-09 13:43:34]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/v8/v8/+/9c7b87269c5220c7b56574c41d37e2add92...