Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2622423002: Remove unused LauncherItemController::IsVisible() (Closed)

Created:
3 years, 11 months ago by msw
Modified:
3 years, 11 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused LauncherItemController::IsVisible() Use was removed in https://codereview.chromium.org/2462753002/ BUG=557406 TEST=Compiles R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2622423002 Cr-Commit-Position: refs/heads/master@{#443343} Committed: https://chromium.googlesource.com/chromium/src/+/1c35a5a7b2dfd2b0767c18f52feb09af1bb765d3

Patch Set 1 #

Messages

Total messages: 21 (17 generated)
msw
Hey James, please take a look; thanks!
3 years, 11 months ago (2017-01-12 02:04:50 UTC) #3
James Cook
LGTM. Hooray for dead code removal! I wish we had something like go/scythe for chrome.
3 years, 11 months ago (2017-01-12 18:17:14 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622423002/1
3 years, 11 months ago (2017-01-12 20:20:30 UTC) #18
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 20:30:44 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1c35a5a7b2dfd2b0767c18f52feb...

Powered by Google App Engine
This is Rietveld 408576698