Compute initial values for registered custom properties.

Compute initial values for registered custom properties.

This patch makes initial values for registered custom properties go
through computation, so initial values like calc(10px) end up as 10px
when accessed through getComputedStyle. As per css-cascade logic they
would normally go through regular computation anyway, but since we
skip this for registered properties for efficiency we need to handle
this case specially.

BUG=671490
Review-Url: https://codereview.chromium.org/2622403006
Cr-Commit-Position: refs/heads/master@{#443847}
Committed: https://chromium.googlesource.com/chromium/src/+/8a637421ef6b1bbfe05708f814a914e57c17a8b6

[Timothy Loh, 2017-01-13 05:06:14]

The CQ bit was checked by timloh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 05:06:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Timothy Loh, 2017-01-13 05:07:40]

timloh@chromium.org changed reviewers:
+ alancutter@chromium.org

[Timothy Loh, 2017-01-13 05:07:41]

https://codereview.chromium.org/2622403006/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
(right):

https://codereview.chromium.org/2622403006/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp:1303: if
((primitiveValue.isCalculated() &&
Apparently we didn't have any tests previously that used other calcs (like
<time>) and went through computation, this logic is now tested by
custom-properties/register-property-syntax-parsing.html for the initial values
there.

[alancutter (OOO until 2018), 2017-01-13 08:02:14]

lgtm

[commit-bot: I haz the power, 2017-01-13 08:07:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 08:07:56]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Timothy Loh, 2017-01-15 22:38:55]

The CQ bit was checked by timloh@chromium.org

[commit-bot: I haz the power, 2017-01-15 22:39:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 02:16:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 02:16:06]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[meade_UTC10, 2017-01-16 02:21:36]

meade@chromium.org changed reviewers:
+ meade@chromium.org

[meade_UTC10, 2017-01-16 02:21:36]

lgtm

[Timothy Loh, 2017-01-16 03:56:31]

The CQ bit was checked by timloh@chromium.org

[Timothy Loh, 2017-01-16 03:56:31]

The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org,
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2622403006/#ps20001
(title: "initialise CSSToLengthConversionData nicer")

[commit-bot: I haz the power, 2017-01-16 03:56:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 05:14:11]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484538991035340,
"parent_rev": "32bac3b4c95c52cc6820ea90bf60e24e0c745ff0", "commit_rev":
"8a637421ef6b1bbfe05708f814a914e57c17a8b6"}

[commit-bot: I haz the power, 2017-01-16 05:15:07]

Description was changed from

==========
Compute initial values for registered custom properties.

This patch makes initial values for registered custom properties go
through computation, so initial values like calc(10px) end up as 10px
when accessed through getComputedStyle. As per css-cascade logic they
would normally go through regular computation anyway, but since we
skip this for registered properties for efficiency we need to handle
this case specially.

BUG=671490
==========

to

==========
Compute initial values for registered custom properties.

This patch makes initial values for registered custom properties go
through computation, so initial values like calc(10px) end up as 10px
when accessed through getComputedStyle. As per css-cascade logic they
would normally go through regular computation anyway, but since we
skip this for registered properties for efficiency we need to handle
this case specially.

BUG=671490

Review-Url: https://codereview.chromium.org/2622403006
Cr-Commit-Position: refs/heads/master@{#443847}
Committed:
https://chromium.googlesource.com/chromium/src/+/8a637421ef6b1bbfe05708f814a9...
==========

[commit-bot: I haz the power, 2017-01-16 05:15:08]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8a637421ef6b1bbfe05708f814a9...