Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 2622403005: Use correct Info.plist for web shell EarlGrey tests. (Closed)

Created:
3 years, 11 months ago by baxley
Modified:
3 years, 11 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use correct Info.plist for web shell EarlGrey tests. The EarlGrey tests were not using the apps Info.plist file, which resulted in UIFileSharingEnabled not being set for tests. BUG=676735 Review-Url: https://codereview.chromium.org/2622403005 Cr-Commit-Position: refs/heads/master@{#443489} Committed: https://chromium.googlesource.com/chromium/src/+/089eff58490359a9eeebe61a104baa629ce5a1df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ios/web/shell/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
baxley
3 years, 11 months ago (2017-01-13 00:49:34 UTC) #2
Eugene But (OOO till 7-30)
lgtm
3 years, 11 months ago (2017-01-13 01:36:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622403005/1
3 years, 11 months ago (2017-01-13 02:49:05 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 04:34:31 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/089eff58490359a9eeebe61a104b...

Powered by Google App Engine
This is Rietveld 408576698