Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2622403002: Clear data for origin if no files found (Closed)

Created:
3 years, 11 months ago by jrummell
Modified:
3 years, 11 months ago
Reviewers:
nasko
CC:
chromium-reviews, jam, wjmaclean, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clear data for origin if no files found Currently PluginPrivateDataByOriginChecker only deletes all the data for the specified origin if it finds at least one file that matches the time range specified. However, if the origin has no files, it should be cleaned up as well. Adds a test that deletes the file for a particular origin before clearing all PluginPrivate storage to verify it works. BUG=678314 TEST=new content_unittest passes Review-Url: https://codereview.chromium.org/2622403002 Cr-Commit-Position: refs/heads/master@{#443320} Committed: https://chromium.googlesource.com/chromium/src/+/bd3656df6d9951d33d5ec0373996679fe0bfb571

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -1 line) Patch
M content/browser/plugin_private_storage_helper.cc View 3 chunks +11 lines, -0 lines 0 comments Download
M content/browser/storage_partition_impl_unittest.cc View 5 chunks +50 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
jrummell
PTAL.
3 years, 11 months ago (2017-01-12 01:15:09 UTC) #2
nasko
LGTM
3 years, 11 months ago (2017-01-12 19:05:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622403002/1
3 years, 11 months ago (2017-01-12 19:10:14 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 19:18:06 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bd3656df6d9951d33d5ec0373996...

Powered by Google App Engine
This is Rietveld 408576698