Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2622393003: Quick View: Rename Resolution to Dimension. (Closed)

Created:
3 years, 11 months ago by oka
Modified:
3 years, 11 months ago
Reviewers:
fukino
CC:
chromium-reviews, extensions-reviews_chromium.org, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, fukino+watch_chromium.org, chromium-apps-reviews_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Quick View: Rename Resolution to Dimension. The metadata stands for the pixel size of the image or the video. Dimension is more appropriate name for this than resolution. TEST=manually. BUG=680011 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2622393003 Cr-Commit-Position: refs/heads/master@{#443171} Committed: https://chromium.googlesource.com/chromium/src/+/a79d034c48e720a020837f5d39ed91a8f5beef50

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M chrome/app/chromeos_strings.grdp View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc View 2 chunks +1 line, -2 lines 0 comments Download
M ui/file_manager/file_manager/foreground/elements/files_metadata_box.html View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/elements/files_metadata_box.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
oka
PTAL.
3 years, 11 months ago (2017-01-12 06:05:17 UTC) #3
fukino
lgtm
3 years, 11 months ago (2017-01-12 06:07:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622393003/1
3 years, 11 months ago (2017-01-12 06:20:47 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 06:51:07 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a79d034c48e720a020837f5d39ed...

Powered by Google App Engine
This is Rietveld 408576698