bluetooth: Add characteristic list to DeviceDetailsPage in internals page.

bluetooth: Add characteristic list to DeviceDetailsPage in internals page.

Adds characteristic list to DeviceDetailsPage under service list items.
Sets up event handling pattern from hierachical controls.

Screenshots: https://goo.gl/photos/iqPrF6uWxV4nysHw9

BUG=651282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2622393002
Cr-Commit-Position: refs/heads/master@{#444890}
Committed: https://chromium.googlesource.com/chromium/src/+/7da9cd89d4d18e171323ff7d0d2a93ede0c1d721

[mbrunson, 2017-01-11 22:24:08]

Description was changed from

==========
bluetooth: Add characteristic list to DeviceDetailsPage in internals page.

Adds characteristic list to DeviceDetailsPage under service list items.
Sets up event handling pattern from hierachical controls.

GIF: https://goo.gl/photos/iqPrF6uWxV4nysHw9

BUG=651282
==========

to

==========
bluetooth: Add characteristic list to DeviceDetailsPage in internals page.

Adds characteristic list to DeviceDetailsPage under service list items.
Sets up event handling pattern from hierachical controls.

GIF: https://goo.gl/photos/iqPrF6uWxV4nysHw9

BUG=651282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[mbrunson, 2017-01-12 23:55:00]

Description was changed from

==========
bluetooth: Add characteristic list to DeviceDetailsPage in internals page.

Adds characteristic list to DeviceDetailsPage under service list items.
Sets up event handling pattern from hierachical controls.

GIF: https://goo.gl/photos/iqPrF6uWxV4nysHw9

BUG=651282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
bluetooth: Add characteristic list to DeviceDetailsPage in internals page.

Adds characteristic list to DeviceDetailsPage under service list items.
Sets up event handling pattern from hierachical controls.

Screenshots: https://goo.gl/photos/iqPrF6uWxV4nysHw9

BUG=651282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[mbrunson, 2017-01-13 00:13:27]

The CQ bit was checked by mbrunson@chromium.org to run a CQ dry run

[mbrunson, 2017-01-13 00:13:30]

mbrunson@chromium.org changed reviewers:
+ scheib@chromium.org

[commit-bot: I haz the power, 2017-01-13 00:15:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 04:47:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 04:47:44]

Dry run: This issue passed the CQ dry run.

[scheib, 2017-01-13 05:24:40]

https://codereview.chromium.org/2622393002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/bluetooth_internals/service_list.js (right):

https://codereview.chromium.org/2622393002/diff/60001/chrome/browser/resource...
chrome/browser/resources/bluetooth_internals/service_list.js:126:
onCharacteristicsRequested: function(characteristics) {
Current name implies this is called when they are requested, not when the
request completes. Maybe: onCharacteristicsReturned?

https://codereview.chromium.org/2622393002/diff/60001/device/bluetooth/device.cc
File device/bluetooth/device.cc (right):

https://codereview.chromium.org/2622393002/diff/60001/device/bluetooth/device...
device/bluetooth/device.cc:158: service->GetCharacteristics()) {
for (const auto* characteristic : service->GetCharacteristics()) {

https://codereview.chromium.org/2622393002/diff/60001/device/bluetooth/device...
File device/bluetooth/device_unittest.cc (right):

https://codereview.chromium.org/2622393002/diff/60001/device/bluetooth/device...
device/bluetooth/device_unittest.cc:185: void
GetCharacteristicsCheckForPrecedingCalls(
Maybe names such as:
CheckGetCharacteristicsCount
CheckGetCharacteristicsProperties
to remove the 'GetGet' and also the need to comment the parameter
'expected_count' (in combo with following comment).

https://codereview.chromium.org/2622393002/diff/60001/device/bluetooth/device...
device/bluetooth/device_unittest.cc:201: int num_of_preceding_calls,
Can't num_of_preceding be incremented as a test fixture member variable? That
would remove the need for each test to hard code a literal.

https://codereview.chromium.org/2622393002/diff/60001/device/bluetooth/device...
device/bluetooth/device_unittest.cc:345: Call::EXPECTED, 0 /*
num_of_preceding_calls
Use "//" comment style to force auto-wrapping to not break the comment and stay
with the param.

[mbrunson, 2017-01-13 21:21:13]

https://codereview.chromium.org/2622393002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/bluetooth_internals/service_list.js (right):

https://codereview.chromium.org/2622393002/diff/60001/chrome/browser/resource...
chrome/browser/resources/bluetooth_internals/service_list.js:126:
onCharacteristicsRequested: function(characteristics) {
On 2017/01/13 05:24:40, scheib wrote:
> Current name implies this is called when they are requested, not when the
> request completes. Maybe: onCharacteristicsReturned?

Done.

https://codereview.chromium.org/2622393002/diff/60001/device/bluetooth/device.cc
File device/bluetooth/device.cc (right):

https://codereview.chromium.org/2622393002/diff/60001/device/bluetooth/device...
device/bluetooth/device.cc:158: service->GetCharacteristics()) {
On 2017/01/13 05:24:40, scheib wrote:
> for (const auto* characteristic : service->GetCharacteristics()) {

Done.

https://codereview.chromium.org/2622393002/diff/60001/device/bluetooth/device...
File device/bluetooth/device_unittest.cc (right):

https://codereview.chromium.org/2622393002/diff/60001/device/bluetooth/device...
device/bluetooth/device_unittest.cc:185: void
GetCharacteristicsCheckForPrecedingCalls(
On 2017/01/13 05:24:40, scheib wrote:
> Maybe names such as:
> CheckGetCharacteristicsCount
> CheckGetCharacteristicsProperties
> to remove the 'GetGet' and also the need to comment the parameter
> 'expected_count' (in combo with following comment).

Done.

https://codereview.chromium.org/2622393002/diff/60001/device/bluetooth/device...
device/bluetooth/device_unittest.cc:201: int num_of_preceding_calls,
On 2017/01/13 05:24:40, scheib wrote:
> Can't num_of_preceding be incremented as a test fixture member variable? That
> would remove the need for each test to hard code a literal. 

Done.

https://codereview.chromium.org/2622393002/diff/60001/device/bluetooth/device...
device/bluetooth/device_unittest.cc:345: Call::EXPECTED, 0 /*
num_of_preceding_calls
On 2017/01/13 05:24:40, scheib wrote:
> Use "//" comment style to force auto-wrapping to not break the comment and
stay
> with the param.

I've removed these comments. Done.

[scheib, 2017-01-14 00:07:14]

LGTM, one comment:

https://codereview.chromium.org/2622393002/diff/100001/device/bluetooth/devic...
File device/bluetooth/device_unittest.cc (right):

https://codereview.chromium.org/2622393002/diff/100001/device/bluetooth/devic...
device/bluetooth/device_unittest.cc:374: // Client: Sends multiple requests for
services.
for characteristics

[mbrunson, 2017-01-14 01:49:33]

https://codereview.chromium.org/2622393002/diff/100001/device/bluetooth/devic...
File device/bluetooth/device_unittest.cc (right):

https://codereview.chromium.org/2622393002/diff/100001/device/bluetooth/devic...
device/bluetooth/device_unittest.cc:374: // Client: Sends multiple requests for
services.
On 2017/01/14 00:07:14, scheib wrote:
> for characteristics

Done.

[mbrunson, 2017-01-14 02:28:35]

The CQ bit was checked by mbrunson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-14 02:29:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mbrunson, 2017-01-14 02:29:12]

mbrunson@chromium.org changed reviewers:
+ dcheng@chromium.org, dpapad@chromium.org

[mbrunson, 2017-01-14 02:29:13]

OWNERS review, please.

dcheng:
  device/bluetooth/public/interfaces/device.mojom
  device/bluetooth/public/interfaces/properties_struct_traits.h

dpapad:
  chrome/browser/browser_resources.grd
  chrome/browser/resources/bluetooth_internals/bluetooth_internals.html
  chrome/browser/resources/bluetooth_internals/characteristic_list.js
  chrome/browser/resources/bluetooth_internals/device_details_page.js
  chrome/browser/resources/bluetooth_internals/expandable_list.js
  chrome/browser/resources/bluetooth_internals/service_list.js
  chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals_ui.cc

[commit-bot: I haz the power, 2017-01-14 04:01:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-14 04:01:55]

Dry run: This issue passed the CQ dry run.

[dpapad, 2017-01-17 20:01:01]

https://codereview.chromium.org/2622393002/diff/140001/chrome/browser/resourc...
File chrome/browser/resources/bluetooth_internals/device_details_page.js
(right):

https://codereview.chromium.org/2622393002/diff/140001/chrome/browser/resourc...
chrome/browser/resources/bluetooth_internals/device_details_page.js:89:
event.target.onCharacteristicsReturned([]);
I am confused about what is happening here.

https://codereview.chromium.org/2622393002/diff/140001/chrome/browser/resourc...
chrome/browser/resources/bluetooth_internals/device_details_page.js:95:
event.target.onCharacteristicsReturned(
This strikes me as odd. Instead of calling a method on the |event.target| why
don't we handle that event from within the |event.target| itself
(ServiceListItem)?

https://codereview.chromium.org/2622393002/diff/140001/chrome/browser/resourc...
File chrome/browser/resources/bluetooth_internals/expandable_list.js (right):

https://codereview.chromium.org/2622393002/diff/140001/chrome/browser/resourc...
chrome/browser/resources/bluetooth_internals/expandable_list.js:52:
toggleExpand_: function() {
Things need to be renamed. The event listener "toggleExpand_" makes it sound
that it just toggles a CSS class, but now it also calls an abstract onExpand
method. Should it be reverse?


this.briefContent_.addEventListener('click', this.onExpand_.bind(this));

...

// Defined by subclasses.
onExpandInternal: function(expanded)() {},

onExpand_: function() {
  this.classList.toggle('expanded')
  this.onExpandInternal(); //
}

https://codereview.chromium.org/2622393002/diff/140001/chrome/browser/resourc...
File chrome/browser/resources/bluetooth_internals/service_list.js (right):

https://codereview.chromium.org/2622393002/diff/140001/chrome/browser/resourc...
chrome/browser/resources/bluetooth_internals/service_list.js:107: return;
Use braces when the "if" condition spans multiple lines.

[mbrunson, 2017-01-17 21:05:49]

https://codereview.chromium.org/2622393002/diff/140001/chrome/browser/resourc...
File chrome/browser/resources/bluetooth_internals/device_details_page.js
(right):

https://codereview.chromium.org/2622393002/diff/140001/chrome/browser/resourc...
chrome/browser/resources/bluetooth_internals/device_details_page.js:95:
event.target.onCharacteristicsReturned(
On 2017/01/17 20:01:01, dpapad wrote:
> This strikes me as odd. Instead of calling a method on the |event.target| why
> don't we handle that event from within the |event.target| itself
> (ServiceListItem)?

I've been juggling solutions to this issue. I'm creating a hierarchical user
interface which will have 3 levels of controls: services, characteristics, and
descriptors.

I figured it would be a better for these hierarchical controls to fire events to
request this data and then the control would only have the responsibility of
formatting and showing the data once it received it. The main issue with this is
that the target of the event can be ambiguous at the top level which is why I
resorted to using |event.target|. This separates the responsibility of creating
a device connection and fetching the data from displaying the data.

Alternatively, I could call a function at the top level and pass the data down
through the levels or set the data on the ArrayDataModel |dataModel| directly.
These are more explicit but would require more logic to find the right spot to
pass/set the data.

What do you think?

https://codereview.chromium.org/2622393002/diff/140001/chrome/browser/resourc...
File chrome/browser/resources/bluetooth_internals/expandable_list.js (right):

https://codereview.chromium.org/2622393002/diff/140001/chrome/browser/resourc...
chrome/browser/resources/bluetooth_internals/expandable_list.js:52:
toggleExpand_: function() {
On 2017/01/17 20:01:01, dpapad wrote:
> Things need to be renamed. The event listener "toggleExpand_" makes it sound
> that it just toggles a CSS class, but now it also calls an abstract onExpand
> method. Should it be reverse?
> 
> 
> this.briefContent_.addEventListener('click', this.onExpand_.bind(this));
> 
> ...
> 
> // Defined by subclasses.
> onExpandInternal: function(expanded)() {},
> 
> onExpand_: function() {
>   this.classList.toggle('expanded')
>   this.onExpandInternal(); //
> }

Done.

https://codereview.chromium.org/2622393002/diff/140001/chrome/browser/resourc...
File chrome/browser/resources/bluetooth_internals/service_list.js (right):

https://codereview.chromium.org/2622393002/diff/140001/chrome/browser/resourc...
chrome/browser/resources/bluetooth_internals/service_list.js:107: return;
On 2017/01/17 20:01:01, dpapad wrote:
> Use braces when the "if" condition spans multiple lines.

Done.

[dpapad, 2017-01-17 22:01:39]

https://codereview.chromium.org/2622393002/diff/140001/chrome/browser/resourc...
File chrome/browser/resources/bluetooth_internals/device_details_page.js
(right):

https://codereview.chromium.org/2622393002/diff/140001/chrome/browser/resourc...
chrome/browser/resources/bluetooth_internals/device_details_page.js:95:
event.target.onCharacteristicsReturned(
> What do you think?

Firing an event from a subcomponent that propagates to the parent, only for the
parent to make a function call to the subcomponent again to pass back the
returned data sounds too indirect. This is using events for 1:1 communication,
whereas events are more suitable for 1:many communication. 

Even so, you would need to cast |event.target| here to some type, so that I as a
reader understand what kind of instance |event.target| is.

Can we make the subcomponent have what it needs (references to global service
objects) to get the information and populate itself directly, so that there is
no need for the parent to pass down any info?

[dcheng, 2017-01-18 00:17:08]

LGTM with nits

Note that one alternative for Properties is to simply send a bitfield, and
define constants in the mojom corresponding to the various bitfield positions. I
think it's slightly more common to do this than define a struct with bools for
each bit.

https://codereview.chromium.org/2622393002/diff/160001/device/bluetooth/publi...
File device/bluetooth/public/interfaces/properties_struct_traits.h (right):

https://codereview.chromium.org/2622393002/diff/160001/device/bluetooth/publi...
device/bluetooth/public/interfaces/properties_struct_traits.h:76: Properties*
output) {
Nit: please out-of-line

[mbrunson, 2017-01-18 02:33:56]

The CQ bit was checked by mbrunson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 02:34:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 05:50:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 05:50:30]

Dry run: This issue passed the CQ dry run.

[mbrunson, 2017-01-18 22:04:24]

https://codereview.chromium.org/2622393002/diff/140001/chrome/browser/resourc...
File chrome/browser/resources/bluetooth_internals/device_details_page.js
(right):

https://codereview.chromium.org/2622393002/diff/140001/chrome/browser/resourc...
chrome/browser/resources/bluetooth_internals/device_details_page.js:95:
event.target.onCharacteristicsReturned(
On 2017/01/17 22:01:39, dpapad wrote:
> > What do you think?
> 
> Firing an event from a subcomponent that propagates to the parent, only for
the
> parent to make a function call to the subcomponent again to pass back the
> returned data sounds too indirect. This is using events for 1:1 communication,
> whereas events are more suitable for 1:many communication. 
> 
> Even so, you would need to cast |event.target| here to some type, so that I as
a
> reader understand what kind of instance |event.target| is.
> 
> Can we make the subcomponent have what it needs (references to global service
> objects) to get the information and populate itself directly, so that there is
> no need for the parent to pass down any info?

Ok. I've created a global service object for this, device_broker, that handles
connections to devices. Each component now has direct access to device
information and only need to know the device address and associated ids to get
the information they need.

https://codereview.chromium.org/2622393002/diff/160001/device/bluetooth/publi...
File device/bluetooth/public/interfaces/properties_struct_traits.h (right):

https://codereview.chromium.org/2622393002/diff/160001/device/bluetooth/publi...
device/bluetooth/public/interfaces/properties_struct_traits.h:76: Properties*
output) {
On 2017/01/18 00:17:08, dcheng wrote:
> Nit: please out-of-line

Removed this completely. Using bitfield and enum for this now.

[dpapad, 2017-01-19 02:01:48]

https://codereview.chromium.org/2622393002/diff/260001/chrome/browser/resourc...
File chrome/browser/resources/bluetooth_internals/device_broker.js (right):

https://codereview.chromium.org/2622393002/diff/260001/chrome/browser/resourc...
chrome/browser/resources/bluetooth_internals/device_broker.js:28: if
(connectedDevices.has(address))
Is this function meant to call adapterBroker.connectToDevice once, and simply
return the same promise for a 2nd connection request (while the 1st one is
already in-flight)? Currently there is a race condition if it gets called twice
in a row for the same device.

If that is the case, instead of checking a map of connectedDevices, we should be
keeping track of promises instead (such that you can return the previously
constructed promise, even if the device has not connected yet).

https://codereview.chromium.org/2622393002/diff/260001/chrome/browser/resourc...
chrome/browser/resources/bluetooth_internals/device_broker.js:31: return
adapter_broker.getAdapterBroker().then(function(adapterBroker) {
Chain instead of nesting, as follows

  ...
  return adapter_broker.getAdapterBroker();
}).then(function(adapterBroker) {
  return adapterBroker.connectToDevice(address);
}).then(....)

[mbrunson, 2017-01-19 03:22:20]

https://codereview.chromium.org/2622393002/diff/260001/chrome/browser/resourc...
File chrome/browser/resources/bluetooth_internals/device_broker.js (right):

https://codereview.chromium.org/2622393002/diff/260001/chrome/browser/resourc...
chrome/browser/resources/bluetooth_internals/device_broker.js:28: if
(connectedDevices.has(address))
On 2017/01/19 02:01:47, dpapad wrote:
> Is this function meant to call adapterBroker.connectToDevice once, and simply
> return the same promise for a 2nd connection request (while the 1st one is
> already in-flight)? Currently there is a race condition if it gets called
twice
> in a row for the same device.
> 
> If that is the case, instead of checking a map of connectedDevices, we should
be
> keeping track of promises instead (such that you can return the previously
> constructed promise, even if the device has not connected yet).

I was less concerned about connection requests in flight and more about
returning the same Device. I have cached the promise here to catch redundant
connection requests as well.

https://codereview.chromium.org/2622393002/diff/260001/chrome/browser/resourc...
chrome/browser/resources/bluetooth_internals/device_broker.js:31: return
adapter_broker.getAdapterBroker().then(function(adapterBroker) {
On 2017/01/19 02:01:47, dpapad wrote:
> Chain instead of nesting, as follows
> 
>   ...
>   return adapter_broker.getAdapterBroker();
> }).then(function(adapterBroker) {
>   return adapterBroker.connectToDevice(address);
> }).then(....)

What function is "return adapter_broker.getAdapterBroker();" in. There's no
chain there.

[dpapad, 2017-01-19 17:41:45]

LGTM with nits.

https://codereview.chromium.org/2622393002/diff/260001/chrome/browser/resourc...
File chrome/browser/resources/bluetooth_internals/device_broker.js (right):

https://codereview.chromium.org/2622393002/diff/260001/chrome/browser/resourc...
chrome/browser/resources/bluetooth_internals/device_broker.js:31: return
adapter_broker.getAdapterBroker().then(function(adapterBroker) {
On 2017/01/19 at 03:22:20, mbrunson wrote:
> On 2017/01/19 02:01:47, dpapad wrote:
> > Chain instead of nesting, as follows
> > 
> >   ...
> >   return adapter_broker.getAdapterBroker();
> > }).then(function(adapterBroker) {
> >   return adapterBroker.connectToDevice(address);
> > }).then(....)
> 
> What function is "return adapter_broker.getAdapterBroker();" in. There's no
chain there.

Ack. I misread the diff.

https://codereview.chromium.org/2622393002/diff/300001/chrome/browser/resourc...
File chrome/browser/resources/bluetooth_internals/device_broker.js (right):

https://codereview.chromium.org/2622393002/diff/300001/chrome/browser/resourc...
chrome/browser/resources/bluetooth_internals/device_broker.js:27: function
connectToDevice(address) {
Nit (optional): You can avoid querying the map twice as follows:

var deviceOrPromise = connectedDevices.get(address) || null;
if (deviceOrPromise !== null)
  return Promise.resolve(deviceOrPromise);

https://codereview.chromium.org/2622393002/diff/300001/chrome/browser/resourc...
File chrome/browser/resources/bluetooth_internals/service_list.js (right):

https://codereview.chromium.org/2622393002/diff/300001/chrome/browser/resourc...
chrome/browser/resources/bluetooth_internals/service_list.js:143: 
Nit (optional):

if (this.servicesRequested_ || this.isLoading())
  return;

this.servicesRequested_ = true;
...

[mbrunson, 2017-01-19 21:18:26]

The CQ bit was checked by mbrunson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 21:19:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 23:18:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 23:18:09]

Dry run: This issue passed the CQ dry run.

[mbrunson, 2017-01-19 23:34:10]

https://codereview.chromium.org/2622393002/diff/300001/chrome/browser/resourc...
File chrome/browser/resources/bluetooth_internals/device_broker.js (right):

https://codereview.chromium.org/2622393002/diff/300001/chrome/browser/resourc...
chrome/browser/resources/bluetooth_internals/device_broker.js:27: function
connectToDevice(address) {
On 2017/01/19 17:41:45, dpapad wrote:
> Nit (optional): You can avoid querying the map twice as follows:
> 
> var deviceOrPromise = connectedDevices.get(address) || null;
> if (deviceOrPromise !== null)
>   return Promise.resolve(deviceOrPromise);

Done.

https://codereview.chromium.org/2622393002/diff/300001/chrome/browser/resourc...
File chrome/browser/resources/bluetooth_internals/service_list.js (right):

https://codereview.chromium.org/2622393002/diff/300001/chrome/browser/resourc...
chrome/browser/resources/bluetooth_internals/service_list.js:143: 
On 2017/01/19 17:41:45, dpapad wrote:
> Nit (optional):
> 
> if (this.servicesRequested_ || this.isLoading())
>   return;
> 
> this.servicesRequested_ = true;
> ...

Done.

[mbrunson, 2017-01-19 23:34:18]

The CQ bit was checked by mbrunson@chromium.org

[mbrunson, 2017-01-19 23:34:18]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org,
dcheng@chromium.org, dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/2622393002/#ps320001
(title: "Simplifications")

[commit-bot: I haz the power, 2017-01-19 23:35:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 00:42:17]

CQ is committing da patch.

Bot data: {"patchset_id": 320001, "attempt_start_ts": 1484868858107580,
"parent_rev": "7c9a1c6ec0f08e65ec3aa5e8a42a239c267ca611", "commit_rev":
"7da9cd89d4d18e171323ff7d0d2a93ede0c1d721"}

[commit-bot: I haz the power, 2017-01-20 00:42:52]

Description was changed from

==========
bluetooth: Add characteristic list to DeviceDetailsPage in internals page.

Adds characteristic list to DeviceDetailsPage under service list items.
Sets up event handling pattern from hierachical controls.

Screenshots: https://goo.gl/photos/iqPrF6uWxV4nysHw9

BUG=651282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
bluetooth: Add characteristic list to DeviceDetailsPage in internals page.

Adds characteristic list to DeviceDetailsPage under service list items.
Sets up event handling pattern from hierachical controls.

Screenshots: https://goo.gl/photos/iqPrF6uWxV4nysHw9

BUG=651282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2622393002
Cr-Commit-Position: refs/heads/master@{#444890}
Committed:
https://chromium.googlesource.com/chromium/src/+/7da9cd89d4d18e171323ff7d0d2a...
==========

[commit-bot: I haz the power, 2017-01-20 00:42:53]

Committed patchset #17 (id:320001) as
https://chromium.googlesource.com/chromium/src/+/7da9cd89d4d18e171323ff7d0d2a...