Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 2622333002: VR: Fix timing of tap event (Closed)

Created:
3 years, 11 months ago by asimjour1
Modified:
3 years, 11 months ago
Reviewers:
mthiesse
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

VR: Fix timing of tap event Fixed the conversion of timestamps in vr_input_manager BUG= Review-Url: https://codereview.chromium.org/2622333002 Cr-Commit-Position: refs/heads/master@{#443081} Committed: https://chromium.googlesource.com/chromium/src/+/ab927387c9bf41a4b240b9210aa0d3cee60f3a93

Patch Set 1 #

Patch Set 2 : VR: Fix timing of tap event #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/android/vr_shell/vr_input_manager.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
asimjour1
PTAL
3 years, 11 months ago (2017-01-11 19:39:56 UTC) #2
asimjour1
PTAL
3 years, 11 months ago (2017-01-11 19:56:51 UTC) #3
mthiesse
lgtm
3 years, 11 months ago (2017-01-11 20:03:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622333002/20001
3 years, 11 months ago (2017-01-11 20:04:10 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/211253)
3 years, 11 months ago (2017-01-11 20:20:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622333002/20001
3 years, 11 months ago (2017-01-11 20:23:27 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/192499)
3 years, 11 months ago (2017-01-11 20:29:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622333002/20001
3 years, 11 months ago (2017-01-11 23:05:26 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 00:30:24 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ab927387c9bf41a4b240b9210aa0...

Powered by Google App Engine
This is Rietveld 408576698