Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 2622303005: Add @MainDex annotation to classes used in child processes. (Closed)

Created:
3 years, 11 months ago by estevenson
Modified:
3 years, 10 months ago
Reviewers:
Torne
CC:
chromium-reviews, agrieve+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add @MainDex annotation to classes used in child processes. These classes are used by render processes during telemetry_perf_unittests on Android. This doesn't cause any problems currently, but is necessary to be fixed for implementing selective JNI registration (https://crbug.com/674937). BUG=657024 Review-Url: https://codereview.chromium.org/2622303005 Cr-Commit-Position: refs/heads/master@{#446999} Committed: https://chromium.googlesource.com/chromium/src/+/27392dadd471377c10736953fedbb18f76cbf2e8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M base/android/java/src/org/chromium/base/EarlyTraceEvent.java View 2 chunks +2 lines, -0 lines 0 comments Download
M base/android/java/src/org/chromium/base/TimeUtils.java View 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (5 generated)
estevenson
ptal torne!
3 years, 10 months ago (2017-01-28 19:16:51 UTC) #3
Torne
lgtm
3 years, 10 months ago (2017-01-30 12:21:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622303005/1
3 years, 10 months ago (2017-01-30 14:56:52 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 16:40:54 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/27392dadd471377c10736953fedb...

Powered by Google App Engine
This is Rietveld 408576698