Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 2622293002: Remove traces of multi-install from GoogleUpdateWinTest. (Closed)

Created:
3 years, 11 months ago by grt (UTC plus 2)
Modified:
3 years, 11 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove traces of multi-install from GoogleUpdateWinTest. BUG=577816 R=pkasting@chromium.org Review-Url: https://codereview.chromium.org/2622293002 Cr-Commit-Position: refs/heads/master@{#443010} Committed: https://chromium.googlesource.com/chromium/src/+/52c36a8d083c2a70c11573111a9f5e7583e22193

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M chrome/browser/google/google_update_win_unittest.cc View 6 chunks +5 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
grt (UTC plus 2)
Hi Peter. This fixes a test that I missed in r438644. Please feel at liberty ...
3 years, 11 months ago (2017-01-11 14:39:21 UTC) #3
grt (UTC plus 2)
On 2017/01/11 14:39:21, grt (UTC plus 1) wrote: > Hi Peter. This fixes a test ...
3 years, 11 months ago (2017-01-11 16:20:51 UTC) #6
Peter Kasting
lgtm
3 years, 11 months ago (2017-01-11 19:24:45 UTC) #8
grt (UTC plus 2)
On 2017/01/11 19:24:45, Peter Kasting wrote: > lgtm Thanks. Tests pass locally, so sending to ...
3 years, 11 months ago (2017-01-11 19:38:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622293002/1
3 years, 11 months ago (2017-01-11 19:39:48 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 22:18:03 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/52c36a8d083c2a70c11573111a9f...

Powered by Google App Engine
This is Rietveld 408576698