Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2622273006: Revert of MediaRecorder: use VideoTrackRecorder::GetPreferredCodecId() when available (Closed)

Created:
3 years, 11 months ago by xlai (Olivia)
Modified:
3 years, 11 months ago
Reviewers:
emircan, mcasas, chfremer
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, chfremer+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of MediaRecorder: use VideoTrackRecorder::GetPreferredCodecId() when available (patchset #5 id:250001 of https://codereview.chromium.org/2624053002/ ) Reason for revert: Suspected CL-to-blame for webkit tests failing on Mac Retina: fast/mediacapturefromelement/HTMLMediaElementCapture-capture.html fast/mediacapturefromelement/CanvasCaptureMediaStream-framerate-0.html https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28retina%29/builds/10965 Original issue's description: > MediaRecorder: use VideoTrackRecorder::GetPreferredCodecId() when available > > This CL adds a static method to VTR to query which > one, if any, is the preferred video codec. > > A new singleton Lazy Leaky class CodecEnumerator is > added to encapsulate poking the VEA to see which > codecs are supported, and to further query > a) the preferred codec id > b) if a given codec is supported > and wraps the previous CodecIdToVEAProfile() > functionality. > > BUG=679946 > > Review-Url: https://codereview.chromium.org/2624053002 > Cr-Commit-Position: refs/heads/master@{#443165} > Committed: https://chromium.googlesource.com/chromium/src/+/904b7a6f6dffa9cee5ac930c37dd591c330d14c6 TBR=emircan@chromium.org,chfremer@chromium.org,mcasas@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=679946 Review-Url: https://codereview.chromium.org/2622273006 Cr-Commit-Position: refs/heads/master@{#443251} Committed: https://chromium.googlesource.com/chromium/src/+/c104b1c42724791fc3dd69ebbea6e915cab8bedc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -96 lines) Patch
M content/browser/webrtc/webrtc_media_recorder_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/media/media_recorder_handler.cc View 3 chunks +2 lines, -8 lines 0 comments Download
M content/renderer/media/video_track_recorder.h View 2 chunks +0 lines, -4 lines 0 comments Download
M content/renderer/media/video_track_recorder.cc View 3 chunks +39 lines, -83 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
xlai (Olivia)
Created Revert of MediaRecorder: use VideoTrackRecorder::GetPreferredCodecId() when available
3 years, 11 months ago (2017-01-12 16:10:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622273006/1
3 years, 11 months ago (2017-01-12 16:10:37 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 16:15:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c104b1c42724791fc3dd69ebbea6...

Powered by Google App Engine
This is Rietveld 408576698