Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2622273004: Fix for issue #28287 (Illegal argument in isolate message : (object is a regular Dart Instance)) (Closed)

Created:
3 years, 11 months ago by siva
Modified:
3 years, 11 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for issue #28287 (Illegal argument in isolate message : (object is a regular Dart Instance)) Ensure that shared type argument lists do not send user defined types across isolates that are spawned using spawnURI. BUG=#28287 R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/f634059f6f321dc6abbb41997405695320eae0a6

Patch Set 1 #

Patch Set 2 : Address self review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M runtime/vm/raw_object.h View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 1 1 chunk +19 lines, -1 line 0 comments Download
M runtime/vm/snapshot.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
siva
3 years, 11 months ago (2017-01-11 21:39:57 UTC) #2
regis
lgtm
3 years, 11 months ago (2017-01-11 21:43:19 UTC) #3
siva
3 years, 11 months ago (2017-01-11 22:39:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f634059f6f321dc6abbb41997405695320eae0a6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698