Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1091)

Unified Diff: runtime/vm/snapshot.cc

Issue 2622273004: Fix for issue #28287 (Illegal argument in isolate message : (object is a regular Dart Instance)) (Closed)
Patch Set: Address self review comments. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/raw_object_snapshot.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/snapshot.cc
diff --git a/runtime/vm/snapshot.cc b/runtime/vm/snapshot.cc
index 13757ecbaee8aaf041b4e0b7ba23ad9f7a4d8d12..b073188befe910a935742705964a68ee5d447de9 100644
--- a/runtime/vm/snapshot.cc
+++ b/runtime/vm/snapshot.cc
@@ -1137,7 +1137,7 @@ void SnapshotReader::ProcessDeferredCanonicalizations() {
}
if (newobj.raw() != objref->raw()) {
ZoneGrowableArray<intptr_t>* patches = backref.patch_records();
- ASSERT(newobj.IsCanonical());
+ ASSERT(newobj.IsNull() || newobj.IsCanonical());
ASSERT(patches != NULL);
// First we replace the back ref table with the canonical object.
*objref = newobj.raw();
« no previous file with comments | « runtime/vm/raw_object_snapshot.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698