Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2622223003: [Sync] Don't call start_callback_ if null in SMTP. (Closed)

Created:
3 years, 11 months ago by maxbogue
Modified:
3 years, 11 months ago
Reviewers:
skym
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Don't call start_callback_ if null in SMTP. Still lost as to why it would be null, but this should stop crashes. BUG=679657, 673883 Review-Url: https://codereview.chromium.org/2622223003 Cr-Commit-Position: refs/heads/master@{#442978} Committed: https://chromium.googlesource.com/chromium/src/+/cd717e257a1933d2f8ee61850407db7332093e6a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M components/sync/model_impl/shared_model_type_processor.cc View 1 chunk +8 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
maxbogue
Sky, PTAL
3 years, 11 months ago (2017-01-11 19:01:59 UTC) #5
skym
lgtm
3 years, 11 months ago (2017-01-11 19:02:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622223003/1
3 years, 11 months ago (2017-01-11 19:15:05 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 19:28:53 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cd717e257a1933d2f8ee61850407...

Powered by Google App Engine
This is Rietveld 408576698