Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2622223002: Call MainThreadLoaderHolder::cancel as a pre-finalizer (Closed)

Created:
3 years, 11 months ago by yhirano
Modified:
3 years, 11 months ago
Reviewers:
haraken, sof
CC:
chromium-reviews, blink-reviews, loading-reviews_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Call MainThreadLoaderHolder::cancel as a pre-finalizer This CL makes MainThreadLoaderHolder::cancel a pre-finalizer in case we are failing to call DocumentThreadableLoader::cancel in it. BUG=667254 Review-Url: https://codereview.chromium.org/2622223002 Cr-Commit-Position: refs/heads/master@{#442889} Committed: https://chromium.googlesource.com/chromium/src/+/6ae8701294c705c937e2955482e11a67aac089b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/core/loader/WorkerThreadableLoader.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
yhirano
PTAL I don't think it's needed, but If I'm correct this bug doesn't happen. So ...
3 years, 11 months ago (2017-01-11 11:46:47 UTC) #4
sof
lgtm
3 years, 11 months ago (2017-01-11 11:56:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622223002/1
3 years, 11 months ago (2017-01-11 11:59:11 UTC) #8
haraken
LGTM
3 years, 11 months ago (2017-01-11 12:16:42 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 13:27:46 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6ae8701294c705c937e2955482e1...

Powered by Google App Engine
This is Rietveld 408576698