Remove clear-data-reduction-proxy-data-savings flag

Remove clear-data-reduction-proxy-data-savings flag

clear-data-reduction-proxy-data-savings flag should be removed, since
users may set this mistakenly and later wonder why there are no savings.

BUG=596625
Review-Url: https://codereview.chromium.org/2622183002
Cr-Commit-Position: refs/heads/master@{#444192}
Committed: https://chromium.googlesource.com/chromium/src/+/f1ac06905684c9b963d358d9c778d58df20719f3

[Raj, 2017-01-11 08:32:03]

The CQ bit was checked by rajendrant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 08:32:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 09:55:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 09:55:05]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Raj, 2017-01-11 18:43:49]

rajendrant@chromium.org changed reviewers:
+ megjablon@chromium.org

[Raj, 2017-01-11 18:43:50]

ptal

https://codereview.chromium.org/2622183002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/snackbar/DataReductionPromoSnackbarController.java
(left):

https://codereview.chromium.org/2622183002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/snackbar/DataReductionPromoSnackbarController.java:84:
if
(CommandLine.getInstance().hasSwitch(CLEAR_DATA_REDUCTION_PROXY_DATA_SAVINGS_SWITCH))
{
Wondering if you are using this for your testing purposes.

[megjablon, 2017-01-12 18:38:29]

https://codereview.chromium.org/2622183002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/snackbar/DataReductionPromoSnackbarController.java
(left):

https://codereview.chromium.org/2622183002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/snackbar/DataReductionPromoSnackbarController.java:84:
if
(CommandLine.getInstance().hasSwitch(CLEAR_DATA_REDUCTION_PROXY_DATA_SAVINGS_SWITCH))
{
On 2017/01/11 18:43:50, Raj wrote:
> Wondering if you are using this for your testing purposes.

Nope, this is fine to remove

https://codereview.chromium.org/2622183002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats_unittest.cc
(right):

https://codereview.chromium.org/2622183002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats_unittest.cc:546:
ClearPrefsOnRestartDisabled) {
Do we need this test if this can't be reset on restart anymore? If we keep it
maybe add a comment on why we have it.

[Raj, 2017-01-12 22:51:50]

https://codereview.chromium.org/2622183002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats_unittest.cc
(right):

https://codereview.chromium.org/2622183002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats_unittest.cc:546:
ClearPrefsOnRestartDisabled) {
On 2017/01/12 18:38:29, megjablon wrote:
> Do we need this test if this can't be reset on restart anymore? If we keep it
> maybe add a comment on why we have it.

This could be removed. But no other test checks if stats are restored from pref
service.
Renamed test for clarity.

[megjablon, 2017-01-13 23:59:48]

lgtm

[Raj, 2017-01-14 00:08:16]

The CQ bit was checked by rajendrant@chromium.org

[commit-bot: I haz the power, 2017-01-14 00:08:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-14 00:17:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-14 00:17:40]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Raj, 2017-01-17 19:07:31]

rajendrant@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Raj, 2017-01-17 19:07:31]

dfalcantara: ptal DataReductionPromoSnackbarController.java

[gone, 2017-01-17 21:44:00]

that file lgtm

[Raj, 2017-01-17 22:13:06]

The CQ bit was checked by rajendrant@chromium.org

[commit-bot: I haz the power, 2017-01-17 22:13:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 23:48:58]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484691186305200,
"parent_rev": "03c86be79f1ccae3c1923d1cff9106d15abdbf21", "commit_rev":
"f1ac06905684c9b963d358d9c778d58df20719f3"}

[commit-bot: I haz the power, 2017-01-17 23:49:30]

Description was changed from

==========
Remove clear-data-reduction-proxy-data-savings flag

clear-data-reduction-proxy-data-savings flag should be removed, since
users may set this mistakenly and later wonder why there are no savings.

BUG=596625
==========

to

==========
Remove clear-data-reduction-proxy-data-savings flag

clear-data-reduction-proxy-data-savings flag should be removed, since
users may set this mistakenly and later wonder why there are no savings.

BUG=596625

Review-Url: https://codereview.chromium.org/2622183002
Cr-Commit-Position: refs/heads/master@{#444192}
Committed:
https://chromium.googlesource.com/chromium/src/+/f1ac06905684c9b963d358d9c778...
==========

[commit-bot: I haz the power, 2017-01-17 23:49:31]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f1ac06905684c9b963d358d9c778...