mediaview: Implement UI.

mediaview: Implement UI.

Media view roots are added to Files.app. They appear just above
"Add new services" button.

BUG=chromium:671511
TEST=Media view works on samus with --enable-features=ArcMediaView
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2622133008
Cr-Commit-Position: refs/heads/master@{#443840}
Committed: https://chromium.googlesource.com/chromium/src/+/35eb49f18a29eb0ad82faf79cf865c5ba03926a8

[Shuhei Takahashi, 2017-01-13 02:38:31]

Description was changed from

==========
mediaview: Implement UI.

Media view roots are added to Files.app. They appear just above
"Add new services" button.

BUG=chromium:671511
TEST=Media view works on samus with --enable-features=ArcMediaView
==========

to

==========
mediaview: Implement UI.

Media view roots are added to Files.app. They appear just above
"Add new services" button.

BUG=chromium:671511
TEST=Media view works on samus with --enable-features=ArcMediaView
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Shuhei Takahashi, 2017-01-13 02:38:57]

The CQ bit was checked by nya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 02:39:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 04:04:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 04:04:01]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[Shuhei Takahashi, 2017-01-13 04:32:03]

The CQ bit was checked by nya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 04:32:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Shuhei Takahashi, 2017-01-13 04:33:08]

nya@chromium.org changed reviewers:
+ fukino@chromium.org, holte@chromium.org

[Shuhei Takahashi, 2017-01-13 04:33:08]

fukino: PTAL all

holte: PTAL tools/metrics/histograms/histograms.xml

[commit-bot: I haz the power, 2017-01-13 05:38:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 05:38:59]

Dry run: This issue passed the CQ dry run.

[fukino, 2017-01-13 06:00:58]

https://codereview.chromium.org/2622133008/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/background/js/volume_info_list_impl.js
(right):

https://codereview.chromium.org/2622133008/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/background/js/volume_info_list_impl.js:75: if
(volumeInfo1.volumeType === VolumeManagerCommon.VolumeType.MEDIA_VIEW) {
I guess the check of volumeInfo2.volumeType is missing here?

https://codereview.chromium.org/2622133008/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/common/js/util.js (right):

https://codereview.chromium.org/2622133008/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/common/js/util.js:953: return
locationInfo.volumeInfo.label;
nit: if Line#953 is unexpected path, could you output error log (like #961)?

[Shuhei Takahashi, 2017-01-13 06:33:43]

https://codereview.chromium.org/2622133008/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/background/js/volume_info_list_impl.js
(right):

https://codereview.chromium.org/2622133008/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/background/js/volume_info_list_impl.js:75: if
(volumeInfo1.volumeType === VolumeManagerCommon.VolumeType.MEDIA_VIEW) {
On 2017/01/13 06:00:58, fukino wrote:
> I guess the check of volumeInfo2.volumeType is missing here?

Since typeIndex1 === typeIndex2 here, volumeInfo1.volumeType ===
volumeInfo2.volumeType.

https://codereview.chromium.org/2622133008/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/common/js/util.js (right):

https://codereview.chromium.org/2622133008/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/common/js/util.js:953: return
locationInfo.volumeInfo.label;
On 2017/01/13 06:00:58, fukino wrote:
> nit: if Line#953 is unexpected path, could you output error log (like #961)?

Done.

[Shuhei Takahashi, 2017-01-13 06:34:15]

The CQ bit was checked by nya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 06:34:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fukino, 2017-01-13 06:37:35]

lgtm

https://codereview.chromium.org/2622133008/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/background/js/volume_info_list_impl.js
(right):

https://codereview.chromium.org/2622133008/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/background/js/volume_info_list_impl.js:75: if
(volumeInfo1.volumeType === VolumeManagerCommon.VolumeType.MEDIA_VIEW) {
On 2017/01/13 06:33:43, Shuhei Takahashi wrote:
> On 2017/01/13 06:00:58, fukino wrote:
> > I guess the check of volumeInfo2.volumeType is missing here?
> 
> Since typeIndex1 === typeIndex2 here, volumeInfo1.volumeType ===
> volumeInfo2.volumeType.

Oh, I see. Thank you for the explanation!

[commit-bot: I haz the power, 2017-01-13 08:53:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 08:53:22]

Dry run: This issue passed the CQ dry run.

[Steven Holte, 2017-01-13 21:25:29]

histograms lgtm

[Shuhei Takahashi, 2017-01-16 02:47:16]

The CQ bit was checked by nya@chromium.org

[commit-bot: I haz the power, 2017-01-16 02:47:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 03:48:26]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484534836514500,
"parent_rev": "3d80af48c3cd0c301ca3f2e5ba0eab568b36ccc9", "commit_rev":
"35eb49f18a29eb0ad82faf79cf865c5ba03926a8"}

[commit-bot: I haz the power, 2017-01-16 03:48:53]

Description was changed from

==========
mediaview: Implement UI.

Media view roots are added to Files.app. They appear just above
"Add new services" button.

BUG=chromium:671511
TEST=Media view works on samus with --enable-features=ArcMediaView
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
mediaview: Implement UI.

Media view roots are added to Files.app. They appear just above
"Add new services" button.

BUG=chromium:671511
TEST=Media view works on samus with --enable-features=ArcMediaView
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2622133008
Cr-Commit-Position: refs/heads/master@{#443840}
Committed:
https://chromium.googlesource.com/chromium/src/+/35eb49f18a29eb0ad82faf79cf86...
==========

[commit-bot: I haz the power, 2017-01-16 03:48:54]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/35eb49f18a29eb0ad82faf79cf86...