Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2622133004: Add support for .so files in generate_gradle.py. (Closed)

Created:
3 years, 11 months ago by sakal-chromium
Modified:
3 years, 11 months ago
Reviewers:
agrieve
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org, Peter Wen
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support for .so files in generate_gradle.py. Only supports ARM for now. BUG=620034 Review-Url: https://codereview.chromium.org/2622133004 Cr-Commit-Position: refs/heads/master@{#443191} Committed: https://chromium.googlesource.com/chromium/src/+/50e9d9c4ee8bd08fa12ed7e8715b42495a17e0b4

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixes according to agrieve's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -12 lines) Patch
M build/android/gradle/build.gradle.jinja View 1 chunk +6 lines, -5 lines 0 comments Download
M build/android/gradle/generate_gradle.py View 1 7 chunks +44 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
sakal-chromium
PTAL I am not sure if we should try to run ninja to compile these ...
3 years, 11 months ago (2017-01-11 14:38:32 UTC) #4
agrieve
lgtm https://codereview.chromium.org/2622133004/diff/1/build/android/gradle/generate_gradle.py File build/android/gradle/generate_gradle.py (right): https://codereview.chromium.org/2622133004/diff/1/build/android/gradle/generate_gradle.py#newcode242 build/android/gradle/generate_gradle.py:242: nit: py style is for 2 blank lines ...
3 years, 11 months ago (2017-01-11 20:10:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622133004/20001
3 years, 11 months ago (2017-01-12 08:38:48 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 09:41:47 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/50e9d9c4ee8bd08fa12ed7e8715b...

Powered by Google App Engine
This is Rietveld 408576698