Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 2622103005: [Signin iOS] Reload the Account Selector screen when identities change (Closed)

Created:
3 years, 11 months ago by bzanotti
Modified:
3 years, 11 months ago
Reviewers:
lpromero
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Signin iOS] Reload the Account Selector screen when identities change The model was already being reloaded but not the the collection view, this could cause crashes as the collection view and its model were not in sync anymore. The collection view is now reloaded as well. BUG=680098 Review-Url: https://codereview.chromium.org/2622103005 Cr-Commit-Position: refs/heads/master@{#443243} Committed: https://chromium.googlesource.com/chromium/src/+/bba0e6692f70aa800b78bedcba9bc3d8ae6fff26

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ios/chrome/browser/ui/authentication/signin_account_selector_view_controller.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
bzanotti
Please take a look.
3 years, 11 months ago (2017-01-12 14:40:22 UTC) #2
lpromero
lgtm
3 years, 11 months ago (2017-01-12 15:42:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622103005/1
3 years, 11 months ago (2017-01-12 15:43:14 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 15:54:28 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bba0e6692f70aa800b78bedcba9b...

Powered by Google App Engine
This is Rietveld 408576698