Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2622103003: ash: Tune shutdown timer in TabletPowerButtonController and shutdown white animation speed (Closed)

Created:
3 years, 11 months ago by Qiang(Joe) Xu
Modified:
3 years, 11 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org, derat+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ash: Tune shutdown timer in TabletPowerButtonController and shutdown white animation speed Changes: (1) shutdown_timer_ in TabletPowerButtonController changes from 1000ms to 500ms. (2) animation_speed_shutdown is set to 2500ms for touch view enabled device case. This change follows the new timing guideline in go/touchview-power. BUG=633304 TEST=tested on device Review-Url: https://codereview.chromium.org/2622103003 Cr-Commit-Position: refs/heads/master@{#443012} Committed: https://chromium.googlesource.com/chromium/src/+/1b5567e091c5aafff29f019055685e962979301a

Patch Set 1 #

Patch Set 2 : make it differentiate on touchViewEnabled #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M ash/system/chromeos/power/tablet_power_button_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/session_state_animator.cc View 1 3 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 14 (10 generated)
Qiang(Joe) Xu
Hi Daniel, ptal, thanks!
3 years, 11 months ago (2017-01-11 17:31:23 UTC) #4
Daniel Erat
lgtm
3 years, 11 months ago (2017-01-11 22:03:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622103003/20001
3 years, 11 months ago (2017-01-11 22:10:36 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 22:20:24 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1b5567e091c5aafff29f01905568...

Powered by Google App Engine
This is Rietveld 408576698