Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2622083006: Make the SYSLOG presubmit check only check changed lines. (Closed)

Created:
3 years, 11 months ago by pastarmovj
Modified:
3 years, 11 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make the SYSLOG presubmit check only check changed lines. The check as it is now was spamming too many unrelated changes. Also make output of the check more precise by showing the line number affected. BUG=none Review-Url: https://codereview.chromium.org/2622083006 Cr-Commit-Position: refs/heads/master@{#443200} Committed: https://chromium.googlesource.com/chromium/src/+/032ba5bc897117f80a9b5508b572a9c499a8cff8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M PRESUBMIT.py View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
pastarmovj
Hi Jochen, can you please review this little CL. Thanks, Julian
3 years, 11 months ago (2017-01-12 09:42:00 UTC) #3
jochen (gone - plz use gerrit)
lgtm
3 years, 11 months ago (2017-01-12 09:46:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622083006/1
3 years, 11 months ago (2017-01-12 10:33:33 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 10:42:36 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/032ba5bc897117f80a9b5508b572...

Powered by Google App Engine
This is Rietveld 408576698