Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2622073005: mus: Correctly set the crash-key for mus-gpu. (Closed)

Created:
3 years, 11 months ago by sadrul
Modified:
3 years, 11 months ago
Reviewers:
scottmg
CC:
chromium-reviews, rjkroege, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mus: Correctly set the crash-key for mus-gpu. Make sure the active URL is correctly set for crash reports. BUG=643746, 630895 Review-Url: https://codereview.chromium.org/2622073005 Cr-Commit-Position: refs/heads/master@{#443361} Committed: https://chromium.googlesource.com/chromium/src/+/0e84ee428168105852608f4a900081e58f3084a2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M services/ui/gpu/gpu_service.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
sadrul
Hi! Is this the right thing to do? Ideally, I would use crash_keys::kActiveURL, but that's ...
3 years, 11 months ago (2017-01-12 20:27:47 UTC) #4
scottmg
lgtm
3 years, 11 months ago (2017-01-12 20:31:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622073005/1
3 years, 11 months ago (2017-01-12 20:32:33 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 21:22:07 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0e84ee428168105852608f4a9000...

Powered by Google App Engine
This is Rietveld 408576698