Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 2622073004: Fix IPC and base tests on ASAN Android bot. (Closed)

Created:
3 years, 11 months ago by Jay Civelli
Modified:
3 years, 11 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix IPC and base tests on ASAN Android bot. The argv list passed to the main method when running a test in a subprocess was not NULL terminated, something that the gtest launcher takes advantage of. This was causing an invalid memory read causing failures on the ASAN bots. BUG=680155, 680156 Review-Url: https://codereview.chromium.org/2622073004 Cr-Commit-Position: refs/heads/master@{#443095} Committed: https://chromium.googlesource.com/chromium/src/+/fc0c5aaa4f06389720901ff12af43fe6738515ac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M testing/android/native_test/main_runner.cc View 2 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Jay Civelli
3 years, 11 months ago (2017-01-11 23:01:22 UTC) #5
jbudorick
3 years, 11 months ago (2017-01-11 23:05:12 UTC) #6
jbudorick
On 2017/01/11 23:05:12, jbudorick wrote: er, lgtm
3 years, 11 months ago (2017-01-11 23:05:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622073004/1
3 years, 11 months ago (2017-01-12 00:33:31 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 00:59:46 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fc0c5aaa4f06389720901ff12af4...

Powered by Google App Engine
This is Rietveld 408576698