DescriptionFix getUserMedia so that failure is reported for invalid audio sources.
This is a reland:
* Original CL https://codereview.chromium.org/2623443002/
* The originally reviewed CL is in the first patch.
* A fix for the issue discovered on the "Win7 Tests (dbg)(1)" bot is in the second patch set.
This changes getUserMedia to wait for initialization of local audio sources before issuing the completion callback (either success or failure). Previously, if an error occurs between attempting to start a local audio source and the render side OnStreamCreated callback, getUserMedia would report successful completion with an audio track but no audio would actually be delivered for that track.
BUG=679210
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2622073003
Cr-Commit-Position: refs/heads/master@{#443660}
Committed: https://chromium.googlesource.com/chromium/src/+/5d0910b9e09533bf6dfe128adcfb882bc2d5e845
Patch Set 1 #Patch Set 2 : Don't delete a request object that's on the stack, from inside a callback from that request object … #Patch Set 3 : Change approach to be more conservative. Instead adapt OnAudioSourceStarted to the current design a… #
Total comments: 26
Patch Set 4 : Address comments #Patch Set 5 : Revert cast and layout_test changes #
Total comments: 2
Patch Set 6 : Switch to std::vector and std::unique_ptr #Messages
Total messages: 39 (24 generated)
|