Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2622053004:
ash: Restore previous show state after exiting fullscreen. (Closed)
Descriptionash: Restore previous show state after exiting fullscreen.
exo restores previous show state (for example maximized)
after exiting fullscreen by overriding
ash::wm::WindowStateDelegate::ToggleFullscreen().
And I also observed all chrome windows restore previous show
state. This CL changes the default behavior of ash and make
it consistent to exo and chrome.
Review-Url: https://codereview.chromium.org/2622053004
Cr-Commit-Position: refs/heads/master@{#445289}
Committed: https://chromium.googlesource.com/chromium/src/+/8e4ac11687d58bbc322cb86d9a98b6a87c0b8b12
Patch Set 1 #Patch Set 2 : Fix a typo #Patch Set 3 : Update #Patch Set 4 : Rebase #Patch Set 5 : Add unittest for fullscreen #
Total comments: 12
Patch Set 6 : Update #Patch Set 7 : Rebase #Messages
Total messages: 54 (27 generated)
The CQ bit was checked by penghuang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== ash: Restore previous show state after exiting fullscreen. ========== to ========== ash: Restore previous show state after exiting fullscreen. exo restores previous show state (for example maximized) after exiting fullscreen by overriding ash::wm::WindowStateDelegate::ToggleFullscreen(). And I also observed all chrome windows restore previous show state. This CL changes the default behavior of ash and make it consistent to exo and chrome. ==========
penghuang@chromium.org changed reviewers: + sky@chromium.org
Hi Scott, PTAL. Thanks.
sky@chromium.org changed reviewers: + oshima@chromium.org
Oshima is a better viewer for this than I am. +oshima
Patchset #3 (id:40001) has been deleted
The CQ bit was checked by penghuang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Hi Oshima, I updated this CL as your suggestion offline. PTAL. Thanks. And I will create a separate CL to get rid of views::Widget::SetFullscreen(), or make it use WmWindow::SetFullscreen().
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by penghuang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Thanks, the change lg. can you add a unit test for fullscreen <-> minimize scenario?
On 2017/01/18 01:19:56, oshima wrote: > Thanks, the change lg. > > can you add a unit test for fullscreen <-> minimize scenario? I added unittest for the scenario. PTAL. Thanks.
The CQ bit was checked by penghuang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
Hi sky, could you please take a look changes in ui/ and chrome/ folders? Thanks.
https://codereview.chromium.org/2622053004/diff/100001/chrome/browser/ui/view... File chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.cc (right): https://codereview.chromium.org/2622053004/diff/100001/chrome/browser/ui/view... chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.cc:96: // Use kPreMinimizedShowStateKey in case a window is minimized/hidden. Shouldn't this check the current state and then use the appropriate pre-mimized/fullscreen? https://codereview.chromium.org/2622053004/diff/100001/ui/aura/client/aura_co... File ui/aura/client/aura_constants.h (right): https://codereview.chromium.org/2622053004/diff/100001/ui/aura/client/aura_co... ui/aura/client/aura_constants.h:80: // A property key to store ui::WindowShowState for restoring a window from Do you correctly deal with all state transitions: normal->minimized->fullscreen->minimize->restore (I assume back to normal here). normal->fullscreen->minimize->restore (I assume back to normal). ?
On 2017/01/18 22:59:49, sky wrote: > https://codereview.chromium.org/2622053004/diff/100001/chrome/browser/ui/view... > File chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.cc > (right): > > https://codereview.chromium.org/2622053004/diff/100001/chrome/browser/ui/view... > chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.cc:96: // Use > kPreMinimizedShowStateKey in case a window is minimized/hidden. > Shouldn't this check the current state and then use the appropriate > pre-mimized/fullscreen? > > https://codereview.chromium.org/2622053004/diff/100001/ui/aura/client/aura_co... > File ui/aura/client/aura_constants.h (right): > > https://codereview.chromium.org/2622053004/diff/100001/ui/aura/client/aura_co... > ui/aura/client/aura_constants.h:80: // A property key to store > ui::WindowShowState for restoring a window from > Do you correctly deal with all state transitions: > > normal->minimized->fullscreen->minimize->restore (I assume back to normal here). > > normal->fullscreen->minimize->restore (I assume back to normal). Restore (which sets the state to normal) does. Toggle minimized state (which uses Unminimize) does go back to fullscreen. > > ?
On 2017/01/19 00:40:17, oshima wrote: > On 2017/01/18 22:59:49, sky wrote: > > > https://codereview.chromium.org/2622053004/diff/100001/chrome/browser/ui/view... > > File chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.cc > > (right): > > > > > https://codereview.chromium.org/2622053004/diff/100001/chrome/browser/ui/view... > > chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.cc:96: // Use > > kPreMinimizedShowStateKey in case a window is minimized/hidden. > > Shouldn't this check the current state and then use the appropriate > > pre-mimized/fullscreen? > > > > > https://codereview.chromium.org/2622053004/diff/100001/ui/aura/client/aura_co... > > File ui/aura/client/aura_constants.h (right): > > > > > https://codereview.chromium.org/2622053004/diff/100001/ui/aura/client/aura_co... > > ui/aura/client/aura_constants.h:80: // A property key to store > > ui::WindowShowState for restoring a window from > > Do you correctly deal with all state transitions: > > > > normal->minimized->fullscreen->minimize->restore (I assume back to normal > here). > > > > normal->fullscreen->minimize->restore (I assume back to normal). > > Restore (which sets the state to normal) does. > > Toggle minimized state (which uses Unminimize) does go back to fullscreen. Yes. Unminimize will back to fullscreen.
On 2017/01/19 00:40:17, oshima wrote: > On 2017/01/18 22:59:49, sky wrote: > > > https://codereview.chromium.org/2622053004/diff/100001/chrome/browser/ui/view... > > File chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.cc > > (right): > > > > > https://codereview.chromium.org/2622053004/diff/100001/chrome/browser/ui/view... > > chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.cc:96: // Use > > kPreMinimizedShowStateKey in case a window is minimized/hidden. > > Shouldn't this check the current state and then use the appropriate > > pre-mimized/fullscreen? > > > > > https://codereview.chromium.org/2622053004/diff/100001/ui/aura/client/aura_co... > > File ui/aura/client/aura_constants.h (right): > > > > > https://codereview.chromium.org/2622053004/diff/100001/ui/aura/client/aura_co... > > ui/aura/client/aura_constants.h:80: // A property key to store > > ui::WindowShowState for restoring a window from > > Do you correctly deal with all state transitions: > > > > normal->minimized->fullscreen->minimize->restore (I assume back to normal > here). > > > > normal->fullscreen->minimize->restore (I assume back to normal). > > Restore (which sets the state to normal) does. > > Toggle minimized state (which uses Unminimize) does go back to fullscreen. Yes. Unminimize will back to fullscreen.
https://codereview.chromium.org/2622053004/diff/100001/chrome/browser/ui/view... File chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.cc (right): https://codereview.chromium.org/2622053004/diff/100001/chrome/browser/ui/view... chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.cc:96: // Use kPreMinimizedShowStateKey in case a window is minimized/hidden. On 2017/01/18 22:59:49, sky wrote: > Shouldn't this check the current state and then use the appropriate > pre-mimized/fullscreen? Looks like this function is used for saving the window's position and state. Only the window is minimized or hidden, we need return the state after Unmiminized() is called. If the PreMinimizedShowState is fullscreen, we should just return the fullscreen show state I think. [1] https://cs.chromium.org/chromium/src/extensions/browser/app_window/app_window...
https://codereview.chromium.org/2622053004/diff/100001/chrome/browser/ui/view... File chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.cc (right): https://codereview.chromium.org/2622053004/diff/100001/chrome/browser/ui/view... chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.cc:96: // Use kPreMinimizedShowStateKey in case a window is minimized/hidden. On 2017/01/19 14:12:38, Peng wrote: > On 2017/01/18 22:59:49, sky wrote: > > Shouldn't this check the current state and then use the appropriate > > pre-mimized/fullscreen? > > Looks like this function is used for saving the window's position and state. > Only the window is minimized or hidden, we need return the > state after Unmiminized() is called. If the PreMinimizedShowState is > fullscreen, we should just return the fullscreen show state I think. > > [1] > https://cs.chromium.org/chromium/src/extensions/browser/app_window/app_window... This should return the current state. Why does it need special case minimized? https://codereview.chromium.org/2622053004/diff/100001/chrome/browser/ui/view... chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.cc:97: ui::WindowShowState restore_state = widget()->GetNativeWindow()->GetProperty( Please move this to where it's needed. https://codereview.chromium.org/2622053004/diff/100001/chrome/browser/ui/view... chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.cc:108: ui::SHOW_STATE_DOCKED || Why can't this function return the showstate always? That's what NativeWidgetAura does?
https://codereview.chromium.org/2622053004/diff/100001/chrome/browser/ui/view... File chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.cc (right): https://codereview.chromium.org/2622053004/diff/100001/chrome/browser/ui/view... chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.cc:96: // Use kPreMinimizedShowStateKey in case a window is minimized/hidden. On 2017/01/19 16:58:57, sky wrote: > On 2017/01/19 14:12:38, Peng wrote: > > On 2017/01/18 22:59:49, sky wrote: > > > Shouldn't this check the current state and then use the appropriate > > > pre-mimized/fullscreen? > > > > Looks like this function is used for saving the window's position and state. > > Only the window is minimized or hidden, we need return the > > state after Unmiminized() is called. If the PreMinimizedShowState is > > fullscreen, we should just return the fullscreen show state I think. > > > > [1] > > > https://cs.chromium.org/chromium/src/extensions/browser/app_window/app_window... > > This should return the current state. Why does it need special case minimized? I think this function is used for getting and saving the window's state, position and size. And use those information for re-create the window. For example restarting the chrome browser. So when we restart the chrome process, probably the users do not expect some windows are minimized (hidden). And user may want all windows are in visible states (normal, fullscreen, docked or maximized) I think. https://codereview.chromium.org/2622053004/diff/100001/chrome/browser/ui/view... chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.cc:97: ui::WindowShowState restore_state = widget()->GetNativeWindow()->GetProperty( On 2017/01/19 16:58:57, sky wrote: > Please move this to where it's needed. Done. https://codereview.chromium.org/2622053004/diff/100001/chrome/browser/ui/view... chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.cc:108: ui::SHOW_STATE_DOCKED || On 2017/01/19 16:58:57, sky wrote: > Why can't this function return the showstate always? That's what > NativeWidgetAura does? I cannot find GetRestoredState() in NativeWidgteAura. But anyway, I am not familiar to this function, so I don't want to change the behavior of this function. It could be risky. https://codereview.chromium.org/2622053004/diff/100001/ui/aura/client/aura_co... File ui/aura/client/aura_constants.h (right): https://codereview.chromium.org/2622053004/diff/100001/ui/aura/client/aura_co... ui/aura/client/aura_constants.h:80: // A property key to store ui::WindowShowState for restoring a window from On 2017/01/18 22:59:49, sky wrote: > Do you correctly deal with all state transitions: > > normal->minimized->fullscreen->minimize->restore (I assume back to normal here). > > normal->fullscreen->minimize->restore (I assume back to normal). > > ? normal->minimized->fullscreen->minimize->unminimize should back to fullscreen with my CL. normal->fullscreen->minimize->unminized should backe to fullscreen. Those are tested in unittest. https://codereview.chromium.org/2622053004/diff/100001/ash/wm/window_state_un...
https://codereview.chromium.org/2622053004/diff/100001/chrome/browser/ui/view... File chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.cc (right): https://codereview.chromium.org/2622053004/diff/100001/chrome/browser/ui/view... chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.cc:96: // Use kPreMinimizedShowStateKey in case a window is minimized/hidden. On 2017/01/19 20:20:03, Peng wrote: > On 2017/01/19 16:58:57, sky wrote: > > On 2017/01/19 14:12:38, Peng wrote: > > > On 2017/01/18 22:59:49, sky wrote: > > > > Shouldn't this check the current state and then use the appropriate > > > > pre-mimized/fullscreen? > > > > > > Looks like this function is used for saving the window's position and state. > > > Only the window is minimized or hidden, we need return the > > > state after Unmiminized() is called. If the PreMinimizedShowState is > > > fullscreen, we should just return the fullscreen show state I think. > > > > > > [1] > > > > > > https://cs.chromium.org/chromium/src/extensions/browser/app_window/app_window... > > > > This should return the current state. Why does it need special case minimized? > > I think this function is used for getting and saving the window's state, > position and size. And use those information for re-create the window. For > example restarting the chrome browser. So when we restart the chrome process, > probably the users do not expect some windows are minimized (hidden). And user > may want all windows are in visible states (normal, fullscreen, docked or > maximized) I think. I believe this function is the same as NativeWidgetDelegate::GetWindowPlacement(). I say this as BrowserView::GetRestoredBounds(), which is overriding the same function, calls NativeWidgetDelegate::GetWindowPlacement(). Looking at the implementation of NativeWidgetAura::GetWindowPlacement() it seems to return the current show state. Same thing goes for DesktopNativeWidgetAura, but that path involves a hop to the WindowTreeHost.
https://codereview.chromium.org/2622053004/diff/100001/chrome/browser/ui/view... File chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.cc (right): https://codereview.chromium.org/2622053004/diff/100001/chrome/browser/ui/view... chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.cc:96: // Use kPreMinimizedShowStateKey in case a window is minimized/hidden. On 2017/01/19 21:55:38, sky wrote: > On 2017/01/19 20:20:03, Peng wrote: > > On 2017/01/19 16:58:57, sky wrote: > > > On 2017/01/19 14:12:38, Peng wrote: > > > > On 2017/01/18 22:59:49, sky wrote: > > > > > Shouldn't this check the current state and then use the appropriate > > > > > pre-mimized/fullscreen? > > > > > > > > Looks like this function is used for saving the window's position and > state. > > > > Only the window is minimized or hidden, we need return the > > > > state after Unmiminized() is called. If the PreMinimizedShowState is > > > > fullscreen, we should just return the fullscreen show state I think. > > > > > > > > [1] > > > > > > > > > > https://cs.chromium.org/chromium/src/extensions/browser/app_window/app_window... > > > > > > This should return the current state. Why does it need special case > minimized? > > > > I think this function is used for getting and saving the window's state, > > position and size. And use those information for re-create the window. For > > example restarting the chrome browser. So when we restart the chrome process, > > probably the users do not expect some windows are minimized (hidden). And user > > may want all windows are in visible states (normal, fullscreen, docked or > > maximized) I think. > > I believe this function is the same as > NativeWidgetDelegate::GetWindowPlacement(). I say this as > BrowserView::GetRestoredBounds(), which is overriding the same function, calls > NativeWidgetDelegate::GetWindowPlacement(). Looking at the implementation of > NativeWidgetAura::GetWindowPlacement() it seems to return the current show > state. Same thing goes for DesktopNativeWidgetAura, but that path involves a hop > to the WindowTreeHost. I tried return current show state in this function. The app window will not restart correctly. See [1] [1] https://drive.google.com/file/d/0B3y_4ZHHx-3hQ0hsb1IyVWxtM1k/view
Can you please investigate why. As I said, it seems NativeWidgetAura returns the current state. -Scott On Fri, Jan 20, 2017 at 11:18 AM, <penghuang@chromium.org> wrote: > > https://codereview.chromium.org/2622053004/diff/100001/chrome/browser/ui/view... > File chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.cc > (right): > > https://codereview.chromium.org/2622053004/diff/100001/chrome/browser/ui/view... > chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.cc:96: > // Use kPreMinimizedShowStateKey in case a window is minimized/hidden. > On 2017/01/19 21:55:38, sky wrote: >> On 2017/01/19 20:20:03, Peng wrote: >> > On 2017/01/19 16:58:57, sky wrote: >> > > On 2017/01/19 14:12:38, Peng wrote: >> > > > On 2017/01/18 22:59:49, sky wrote: >> > > > > Shouldn't this check the current state and then use the > appropriate >> > > > > pre-mimized/fullscreen? >> > > > >> > > > Looks like this function is used for saving the window's > position and >> state. >> > > > Only the window is minimized or hidden, we need return the >> > > > state after Unmiminized() is called. If the > PreMinimizedShowState is >> > > > fullscreen, we should just return the fullscreen show state I > think. >> > > > >> > > > [1] >> > > > >> > > >> > >> > https://cs.chromium.org/chromium/src/extensions/browser/app_window/app_window... >> > > >> > > This should return the current state. Why does it need special > case >> minimized? >> > >> > I think this function is used for getting and saving the window's > state, >> > position and size. And use those information for re-create the > window. For >> > example restarting the chrome browser. So when we restart the chrome > process, >> > probably the users do not expect some windows are minimized > (hidden). And user >> > may want all windows are in visible states (normal, fullscreen, > docked or >> > maximized) I think. >> >> I believe this function is the same as >> NativeWidgetDelegate::GetWindowPlacement(). I say this as >> BrowserView::GetRestoredBounds(), which is overriding the same > function, calls >> NativeWidgetDelegate::GetWindowPlacement(). Looking at the > implementation of >> NativeWidgetAura::GetWindowPlacement() it seems to return the current > show >> state. Same thing goes for DesktopNativeWidgetAura, but that path > involves a hop >> to the WindowTreeHost. > > I tried return current show state in this function. The app window will > not restart correctly. See [1] > > [1] https://drive.google.com/file/d/0B3y_4ZHHx-3hQ0hsb1IyVWxtM1k/view > > https://codereview.chromium.org/2622053004/ -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
On 2017/01/20 20:27:59, sky wrote: > Can you please investigate why. As I said, it seems NativeWidgetAura > returns the current state. > > -Scott SaveWindowPlacement() saves the placement from NativeWidgetAura::GetWindowPlacement(). It doesn't care window's state. It only saves if the window is maximized or not. When the placement is loaded, chrome will set the restored window placement back, and put the window in normal or maximized state. I think ChromeNativeAppWindowViewsAura::GetRestoredState() is for apps. I think apps use different code path. [1] https://cs.chromium.org/chromium/src/chrome/browser/ui/views/chrome_views_del... > > On Fri, Jan 20, 2017 at 11:18 AM, <mailto:penghuang@chromium.org> wrote: > > > > > https://codereview.chromium.org/2622053004/diff/100001/chrome/browser/ui/view... > > File chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.cc > > (right): > > > > > https://codereview.chromium.org/2622053004/diff/100001/chrome/browser/ui/view... > > chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.cc:96: > > // Use kPreMinimizedShowStateKey in case a window is minimized/hidden. > > On 2017/01/19 21:55:38, sky wrote: > >> On 2017/01/19 20:20:03, Peng wrote: > >> > On 2017/01/19 16:58:57, sky wrote: > >> > > On 2017/01/19 14:12:38, Peng wrote: > >> > > > On 2017/01/18 22:59:49, sky wrote: > >> > > > > Shouldn't this check the current state and then use the > > appropriate > >> > > > > pre-mimized/fullscreen? > >> > > > > >> > > > Looks like this function is used for saving the window's > > position and > >> state. > >> > > > Only the window is minimized or hidden, we need return the > >> > > > state after Unmiminized() is called. If the > > PreMinimizedShowState is > >> > > > fullscreen, we should just return the fullscreen show state I > > think. > >> > > > > >> > > > [1] > >> > > > > >> > > > >> > > >> > > > https://cs.chromium.org/chromium/src/extensions/browser/app_window/app_window... > >> > > > >> > > This should return the current state. Why does it need special > > case > >> minimized? > >> > > >> > I think this function is used for getting and saving the window's > > state, > >> > position and size. And use those information for re-create the > > window. For > >> > example restarting the chrome browser. So when we restart the chrome > > process, > >> > probably the users do not expect some windows are minimized > > (hidden). And user > >> > may want all windows are in visible states (normal, fullscreen, > > docked or > >> > maximized) I think. > >> > >> I believe this function is the same as > >> NativeWidgetDelegate::GetWindowPlacement(). I say this as > >> BrowserView::GetRestoredBounds(), which is overriding the same > > function, calls > >> NativeWidgetDelegate::GetWindowPlacement(). Looking at the > > implementation of > >> NativeWidgetAura::GetWindowPlacement() it seems to return the current > > show > >> state. Same thing goes for DesktopNativeWidgetAura, but that path > > involves a hop > >> to the WindowTreeHost. > > > > I tried return current show state in this function. The app window will > > not restart correctly. See [1] > > > > [1] https://drive.google.com/file/d/0B3y_4ZHHx-3hQ0hsb1IyVWxtM1k/view > > > > https://codereview.chromium.org/2622053004/ > > -- > You received this message because you are subscribed to the Google Groups > "Chromium-reviews" group. > To unsubscribe from this group and stop receiving emails from it, send an email > to mailto:chromium-reviews+unsubscribe@chromium.org. >
Ok, thanks for the clarification. LGTM
And thanks for the patience! On Fri, Jan 20, 2017 at 4:11 PM, <sky@chromium.org> wrote: > Ok, thanks for the clarification. LGTM > > https://codereview.chromium.org/2622053004/ -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
On 2017/01/21 00:31:42, sky wrote: > And thanks for the patience! > > On Fri, Jan 20, 2017 at 4:11 PM, <mailto:sky@chromium.org> wrote: > > Ok, thanks for the clarification. LGTM > > > > https://codereview.chromium.org/2622053004/ > > -- > You received this message because you are subscribed to the Google Groups > "Chromium-reviews" group. > To unsubscribe from this group and stop receiving emails from it, send an email > to mailto:chromium-reviews+unsubscribe@chromium.org. > Thanks for review.
The CQ bit was checked by penghuang@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org Link to the patchset: https://codereview.chromium.org/2622053004/#ps120001 (title: "Update")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
The CQ bit was checked by penghuang@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org, sky@chromium.org Link to the patchset: https://codereview.chromium.org/2622053004/#ps140001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by penghuang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 140001, "attempt_start_ts": 1485018442634510,
"parent_rev": "9fa52ef0da5a0a6e03a15c4c72d8021567070127", "commit_rev":
"8e4ac11687d58bbc322cb86d9a98b6a87c0b8b12"}
Message was sent while issue was closed.
Description was changed from ========== ash: Restore previous show state after exiting fullscreen. exo restores previous show state (for example maximized) after exiting fullscreen by overriding ash::wm::WindowStateDelegate::ToggleFullscreen(). And I also observed all chrome windows restore previous show state. This CL changes the default behavior of ash and make it consistent to exo and chrome. ========== to ========== ash: Restore previous show state after exiting fullscreen. exo restores previous show state (for example maximized) after exiting fullscreen by overriding ash::wm::WindowStateDelegate::ToggleFullscreen(). And I also observed all chrome windows restore previous show state. This CL changes the default behavior of ash and make it consistent to exo and chrome. Review-Url: https://codereview.chromium.org/2622053004 Cr-Commit-Position: refs/heads/master@{#445289} Committed: https://chromium.googlesource.com/chromium/src/+/8e4ac11687d58bbc322cb86d9a98... ==========
Message was sent while issue was closed.
Committed patchset #7 (id:140001) as https://chromium.googlesource.com/chromium/src/+/8e4ac11687d58bbc322cb86d9a98... |
