Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2622043004: Replace OutputCapture with LoggingTestCase in port_testcase.py (Closed)

Created:
3 years, 11 months ago by qyearsley
Modified:
3 years, 11 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace OutputCapture with LoggingTestCase in port_testcase.py Reason: I think that this way is slightly more readable and straightforward than the way with OutputCapture. BUG=681428 Review-Url: https://codereview.chromium.org/2622043004 Cr-Commit-Position: refs/heads/master@{#444441} Committed: https://chromium.googlesource.com/chromium/src/+/8c0c9992b03751b32210ea1fa5ef2513da642cdb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -20 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py View 3 chunks +23 lines, -20 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
qyearsley
3 years, 11 months ago (2017-01-16 00:50:20 UTC) #3
jeffcarp
lgtm
3 years, 11 months ago (2017-01-18 19:34:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622043004/1
3 years, 11 months ago (2017-01-18 19:37:59 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 19:45:06 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8c0c9992b03751b32210ea1fa5ef...

Powered by Google App Engine
This is Rietveld 408576698