Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2622043003: Replaced RefPtr::release with std::move in Source/core. (Closed)

Created:
3 years, 11 months ago by Bugs Nash
Modified:
3 years, 11 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-style_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, dglazkov+blink, dshwang, krit, dtapuska+blinkwatch_chromium.org, eae+blinkwatch, Eric Willigers, f(malita), fs, gavinp+loader_chromium.org, gyuyoung2, Nate Chapin, jchaffraix+rendering, kinuko+watch, kouhei+svg_chromium.org, kozyatinskiy+blink_chromium.org, leviw+renderwatch, loading-reviews_chromium.org, loading-reviews+parser_chromium.org, lushnikov+blink_chromium.org, Navid Zolghadr, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, pfeldman+blink_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans, sof, szager+layoutwatch_chromium.org, tyoshino+watch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replaced RefPtr::release with std::move in Source/core. Part of the removal of PassRefPtr. Replaces many of the calls to RefPtr::release with a std::move wrap, which returns a RefPtr instead of a PassRefPtr. As the code currently stands, most methods still expect a PassRefPtr and so the PassRefPtr initialising constructor will be called passing in the RefPtr rvalue, which calls RefPtr::release anyway. Future patches will see these variables changed from PassRefPtr to RefPtr type then RefPtr::release will not be used at all. Does not handle RefPtr::release of non member variables in return statements as these cases sometimes default to move (in the case of returning a local variable). These will be handled in future patches. BUG=494719 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2622043003 Cr-Commit-Position: refs/heads/master@{#443409} Committed: https://chromium.googlesource.com/chromium/src/+/52d6d437288de59def855af9bec777a5d7ac88d6

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -100 lines) Patch
M third_party/WebKit/Source/core/animation/CSSBasicShapeInterpolationType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSBorderImageLengthBoxInterpolationType.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp View 1 chunk +1 line, -1 line 1 comment Download
M third_party/WebKit/Source/core/animation/CSSFilterListInterpolationType.cpp View 4 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSImageListInterpolationType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSImageSliceInterpolationType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSOffsetRotateInterpolationType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSTextIndentInterpolationType.cpp View 3 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CustomCompositorAnimations.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/FilterInterpolationFunctions.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/InterpolationValue.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/InvalidatableInterpolation.cpp View 3 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/animation/ListInterpolationFunctions.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/ListInterpolationFunctions.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/PairwiseInterpolationValue.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/PathInterpolationFunctions.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/SVGTransformListInterpolationType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/ShadowInterpolationFunctions.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/SizeInterpolationFunctions.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/animation/TypedInterpolationValue.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/BasicShapeFunctions.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSSegmentedFontFace.cpp View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/PropertyRegistration.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolverState.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Fullscreen.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/MessagePort.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/DOMTimer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutInline.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutListMarker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutRubyRun.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutScrollbar.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCell.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableRow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableSection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTextFragment.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/TextAutosizer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FormSubmission.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/PingLoader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEDiffuseLightingElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFESpecularLightingElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
Bugs Nash
3 years, 11 months ago (2017-01-11 04:47:02 UTC) #4
alancutter (OOO until 2018)
core/animation lgtm. https://codereview.chromium.org/2622043003/diff/1/third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp File third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp (right): https://codereview.chromium.org/2622043003/diff/1/third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp#newcode244 third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp:244: std::move(start.nonInterpolableValue)); Yay consistency.
3 years, 11 months ago (2017-01-11 05:14:20 UTC) #9
Yuta Kitamura
lgtm
3 years, 11 months ago (2017-01-12 10:29:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622043003/1
3 years, 11 months ago (2017-01-12 20:54:29 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 00:28:44 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/52d6d437288de59def855af9bec7...

Powered by Google App Engine
This is Rietveld 408576698