Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2622033002: [WPT Export] Clean up TODOs (Closed)

Created:
3 years, 11 months ago by jeffcarp
Modified:
3 years, 11 months ago
Reviewers:
qyearsley
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Delete TODOs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/sync_wpt.py View 1 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_exporter.py View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
qyearsley
lgtm https://codereview.chromium.org/2622033002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/w3c/sync_wpt.py File third_party/WebKit/Tools/Scripts/webkitpy/w3c/sync_wpt.py (right): https://codereview.chromium.org/2622033002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/w3c/sync_wpt.py#newcode11 third_party/WebKit/Tools/Scripts/webkitpy/w3c/sync_wpt.py:11: TODO(jeffcarp): move WPT fetch out of its constructor ...
3 years, 11 months ago (2017-01-10 23:07:16 UTC) #1
jeffcarp
https://codereview.chromium.org/2622033002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/w3c/sync_wpt.py File third_party/WebKit/Tools/Scripts/webkitpy/w3c/sync_wpt.py (right): https://codereview.chromium.org/2622033002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/w3c/sync_wpt.py#newcode11 third_party/WebKit/Tools/Scripts/webkitpy/w3c/sync_wpt.py:11: TODO(jeffcarp): move WPT fetch out of its constructor to ...
3 years, 11 months ago (2017-01-11 01:34:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622033002/20001
3 years, 11 months ago (2017-01-11 01:35:05 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 03:43:01 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/995f87df43d91278d4b1e0c5ad86...

Powered by Google App Engine
This is Rietveld 408576698