Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2622003007: Update Reading List icon (Closed)

Created:
3 years, 11 months ago by gambard
Modified:
3 years, 11 months ago
Reviewers:
Olivier
CC:
chromium-reviews, marq+watch_chromium.org, stkhapugin, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Reading List icon Changes the Reading List icon for the empty state with the new offline icon. BUG=680152 Review-Url: https://codereview.chromium.org/2622003007 Cr-Commit-Position: refs/heads/master@{#443199} Committed: https://chromium.googlesource.com/chromium/src/+/3988b62ce2aa6071455afd06e06b94af7a044dd9

Patch Set 1 #

Patch Set 2 : Change icon name #

Messages

Total messages: 10 (4 generated)
gambard
PTAL.
3 years, 11 months ago (2017-01-12 08:32:24 UTC) #2
Olivier
LGTM nit: can we take this opportunity to have a more specific name for the ...
3 years, 11 months ago (2017-01-12 08:34:36 UTC) #3
gambard
Thanks, PTAL.
3 years, 11 months ago (2017-01-12 08:43:21 UTC) #4
Olivier
still lgtm
3 years, 11 months ago (2017-01-12 08:48:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622003007/20001
3 years, 11 months ago (2017-01-12 08:59:34 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 10:35:54 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3988b62ce2aa6071455afd06e06b...

Powered by Google App Engine
This is Rietveld 408576698